Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ACF Builder was missing wrapper methods for two ACF Pro field types:
icon_pickerandseparator.Solution
This change adds the missing field helpers to
FieldsBuilder:addIconPicker()addSeparator()It also updates the
@methodannotations inFieldBuilderso IDE autocomplete and static analysis reflect the supported ACF field API.Impact
This is a backwards-compatible enhancement to the public API. Existing field group builders continue to work as before, and the generated ACF configuration matches the upstream field types for these two additions.
Usage changes
No migration steps are required for existing users. New usage is as follows:
Testing
Added regression coverage for the two missing field helpers.
Command run:
Result:
OK (2 tests, 2 assertions)