The build chip is glyph-only — one label was misaligning a row of eight icons - #2053
Conversation
…ht icons The header strip is icon buttons: each sibling is a FluentButton wrapping exactly one FluentIcon. The build chip was the same except it also rendered 'Last deployed 08-21 22:16', which made it wider than its siblings and pushed its own glyph off their shared centre line. Both reported symptoms — visible text, and one icon sitting at a different height — are that single difference. The text is removed rather than hidden. A media query already dropped it below 720px, so the narrow layout was the intended one all along; it just never applied to the width people actually use. 🚨 The deployment time had to MOVE, not go. Describe's idle tooltip was 'version · instance' and carried no time at all, so deleting the label would have lost 'when was this deployed?' entirely — which the type's own docs call the question people actually bring to it. It is now folded into every state's tooltip, including the update-pending ones, so the one surface the chip still has says everything it has to say. DisplayText is deleted rather than left unrendered: the span was its only consumer, and a record member nothing reads is a field that drifts. Its three tests move to the tooltip and keep their reasoning — WHEN belongs to the reader, WHICH BUILD stays one hover away, and an unknown time is omitted rather than invented. Memex.Portal.Shared.Test 358/358. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR makes the platform build chip in the header strictly glyph-only to keep it visually aligned with the surrounding icon buttons, moving the “last deployed” timestamp from inline text into the tooltip across all chip states.
Changes:
- Removed the inline “last deployed” label from the build chip view and deleted the associated styling.
- Updated
PlatformUpdateChipto dropDisplayTextand always fold deployment time into the tooltip when known. - Adjusted unit tests to validate the deployment time behavior via
Tooltipinstead ofDisplayText.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Memex.Portal.Shared.Test/PlatformUpdateChipTest.cs | Updates assertions to pin deployment-time behavior on Tooltip and removes DisplayText expectations. |
| memex/Memex.Portal.Shared/SelfUpdate/PlatformUpdateChipView.razor | Removes inline label rendering and CSS so the chip is glyph-only. |
| memex/Memex.Portal.Shared/SelfUpdate/PlatformUpdateChip.cs | Removes DisplayText from the record and appends deployment time into the tooltip for all states. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // pushed its own glyph off their shared centre line — visible as one misaligned icon in a | ||
| // row of eight. Dropping the text fixes the row, so the time has to land here or it is | ||
| // simply lost, and "when was this deployed?" is the question the chip exists to answer. | ||
| var withDeployed = (string sentence) => deployed is null ? sentence : $"{sentence} {deployed}."; |
Test Results (shard 2)3 228 tests ±0 3 228 ✅ ±0 8m 24s ⏱️ -3s Results for commit cb1b4f9. ± Comparison against base commit 1661b86. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both. |
Test Results 59 files ±0 59 suites ±0 50m 49s ⏱️ +20s Results for commit cb1b4f9. ± Comparison against base commit 1661b86. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Merging over a red The failure is That alone is not evidence, so I checked the right thing:
Two of six, on main, with no involvement from this branch. Independently, the Expo migration PR (#2056) hit the same suite on both of its runs — a diff containing zero C# files. Recorded on #1384, which is where the population belongs. Local verification for this change: |
The header strip is icon buttons: each sibling is a
FluentButtonwrapping exactly oneFluentIcon. The build chip was the same except it also renderedLast deployed 08-21 22:16— which made it wider than its siblings and pushed its own glyph off their shared centre line.Both reported symptoms — the visible text, and one icon sitting at a different height — are that single difference.
The text is removed, not hidden
A media query already dropped it below 720px:
So the narrow layout was the intended one all along. It just never applied at the width people actually use.
🚨 The deployment time had to move, not go
Describe's idle tooltip wasversion · instanceand carried no time at all. Deleting the label would have lost "when was this deployed?" entirely — which the type's own documentation calls the question people actually bring to it:It is now folded into every state's tooltip, including the two update-pending ones, so the single surface the chip still has says everything it has to say.
DisplayTextis deleted, not left unrenderedThe span was its only consumer. A record member nothing reads is a field that drifts out of agreement with what ships. Its three tests move to the tooltip and keep their reasoning intact — WHEN belongs to the reader, WHICH BUILD stays one hover away, and an unknown time is omitted rather than invented (no epoch date, no "unknown" filler).
Verification
Memex.Portal.Shared.Test358/358, Release with-warnaserror.🤖 Generated with Claude Code