Rename install-talxis-plugin.sh to configure-agent-harness.sh - #26
Merged
Merged
Conversation
It's not just a plugin installer and shouldn't be named after the one thing it currently does — it's the intended home for any other per-harness setup agentbox ends up needing. Also makes the README's Codespaces instructions call out explicitly that a repo with its own devcontainer.json needs to add this step itself: it's easy to end up with a working toolchain but no Skills/MCP registration if it's skipped, since nothing it does is baked into the image. Confirmed this gap for real in a Codespace on a repo that only copied the image reference, not the full template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/scripts/install-talxis-plugin.sh→src/scripts/configure-agent-harness.sh. It's not just a plugin installer, and shouldn't be named after the one thing it currently does — it's the intended home for any other per-harness setup agentbox ends up needing (other marketplaces, settings.json tweaks, etc.), not a one-script-per-plugin pattern. Updates all references (install-features.sh, the Power Platform template'sdevcontainer.json,README.md).devcontainer.json(instead of copying the full template) needs to add thepostCreateCommandstep itself — it's easy to end up with a working toolchain but no Skills/MCP registration otherwise, since nothing this step does is baked into the image.The doc change is prompted by a real gap found while smoke-testing
v1.2.1in an actual Codespace on a repo that only pointedimageatghcr.io/talxis/tools-agentbox/image:latestwithout copying the rest of the template — the toolchain (includingclaude/copilot) was fully present, but no plugin marketplace was registered, exactly because that repo's owndevcontainer.jsonnever had this step.Test plan
bash -non both shell scripts.devcontainer.jsonparses (stripped full-line//comments, thenjson.loads).grep -r install-talxis-pluginreturns nothing repo-wide.Generated by Claude Code