Skip to content

fix(data): five defects in model convert that silently lose or corrupt output #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
david-hudec-networg wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

fix(data): five defects in model convert that silently lose or corrupt output #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a824822
fix(data): keep every N:1 relationship between the same table pair
david-hudec-networg Sep 1, 2026
544a229
fix(data): keep picklist columns whose option set cannot be resolved
david-hudec-networg Sep 1, 2026
e91f294
fix(data): make conversion reproducible
david-hudec-networg Sep 1, 2026
6d6a6dc
fix(data): give a self-referencing N:N two distinct sides
david-hudec-networg Sep 1, 2026
c040d75
fix(data): accept --target plainsql, which was advertised and always …
david-hudec-networg Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 53 additions & 18 deletions src/TALXIS.CLI.Features.Data/DataModelConverter/DataModelConverterService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace TALXIS.CLI.Features.Data.DataModelConverter;
public class DataModelConverterService
{
private static readonly ILogger _logger = TxcLoggerFactory.CreateLogger(nameof(DataModelConverterService));
private static readonly string[] SupportedFormats = ["dbml", "sql", "edmx", "ribbon"];
private static readonly string[] SupportedFormats = ["dbml", "sql", "plainsql", "edmx", "ribbon"];

/// <summary>
/// Parses a Power Platform solution from a solution project folder, a declarations
Expand Down Expand Up @@ -259,7 +259,11 @@ public static ParsedModel ParseModelFolder(string folderPath)
Module module = new();

// Get files named Entity.xml in subfolders
var entityFiles = Directory.GetFiles(folderPath, "Entity.xml", SearchOption.AllDirectories);
// Ordered: Directory.GetFiles gives no ordering guarantee, so without this the
// table, relationship and enum order in the output varies by filesystem and the
// result cannot be committed or diffed.
var entityFiles = Directory.GetFiles(folderPath, "Entity.xml", SearchOption.AllDirectories)
.OrderBy(f => f, StringComparer.Ordinal).ToArray();

foreach (var file in entityFiles)
{
Expand All @@ -284,7 +288,7 @@ public static ParsedModel ParseModelFolder(string folderPath)
// Get files in folder Other/Relationships (directory may not exist in scaffolded solutions)
var relationshipsDir = Path.Combine(folderPath, "Other", "Relationships");
var relationshipFiles = Directory.Exists(relationshipsDir)
? Directory.GetFiles(relationshipsDir, "*.xml", SearchOption.AllDirectories)
? [.. Directory.GetFiles(relationshipsDir, "*.xml", SearchOption.AllDirectories).OrderBy(f => f, StringComparer.Ordinal)]
: Array.Empty<string>();
foreach (var file in relationshipFiles)
{
Expand All @@ -302,7 +306,7 @@ public static ParsedModel ParseModelFolder(string folderPath)
// Get files in folder called OptionSets (directory may not exist in scaffolded solutions)
var optionsetsDir = Path.Combine(folderPath, "OptionSets");
var optionsetFiles = Directory.Exists(optionsetsDir)
? Directory.GetFiles(optionsetsDir, "*.xml", SearchOption.AllDirectories)
? [.. Directory.GetFiles(optionsetsDir, "*.xml", SearchOption.AllDirectories).OrderBy(f => f, StringComparer.Ordinal)]
: Array.Empty<string>();
foreach (var file in optionsetFiles)
{
Expand Down Expand Up @@ -362,15 +366,20 @@ public static ParsedModel ParseModules(List<Module> modules)
List<Table> EntityTables = ParseEntities(modules);
List<OptionsetEnum> EntityOptionSets = ParseOptionSets(modules);

// Remove optionset rows without optionsets defined
// Downgrade optionset rows whose optionset is not resolvable here (declared with no
// options, owned by another module, or platform-owned) rather than dropping the column.
var validOptionSetNames = EntityOptionSets.Select(x => x.LocalizedName).ToHashSet(StringComparer.OrdinalIgnoreCase);
foreach (var entity in EntityTables)
foreach (var row in EntityTables
.SelectMany(entity => entity.Rows)
.Where(row =>
row.RowType is (RowType.Picklist or RowType.Multiselectoptionset or RowType.State or RowType.Status or RowType.Bit)
&& !validOptionSetNames.Contains(row.OptionSetName)))
{
entity.Rows = [.. entity.Rows
.Where(row =>
row.RowType is not (RowType.Picklist or RowType.Multiselectoptionset or RowType.State or RowType.Status or RowType.Bit)
|| validOptionSetNames.Contains(row.OptionSetName)
)];
// Clearing OptionSetName is enough and is all that is needed: it is what
// ToDbDiagramNotation prefers over RowType, so leaving it set would make the
// column reference an Enum that was never emitted. RowType is deliberately
// left alone so each translator keeps its own handling for the kind.
row.OptionSetName = string.Empty;
}

// Fill in setnames where missing with placeholder logical names
Expand Down Expand Up @@ -420,6 +429,21 @@ public static List<Relationship> ParseRelationships(List<Module> modules, List<T

var intersectEntityName = relationship.Element("IntersectEntityName").Value;

// A self-referencing N:N resolves both sides to the same column name, which
// emitted the column twice and the same Ref twice -- a DBML parser rejects
// both. Dataverse keeps the real per-side names in metadata
// (Entity1/Entity2IntersectAttribute) and they are author-chosen, not
// derivable: the platform's own example pairs connectionroleid with
// associatedconnectionroleid. Solution XML carries neither, and no intersect
// entity declares its own columns, so the second side is suffixed
// positionally rather than guessed.
var firstRowName = firstEntityTable.LogicalName + "id";
var secondRowName = secondEntityTable.LogicalName + "id";
if (string.Equals(firstRowName, secondRowName, StringComparison.OrdinalIgnoreCase))
{
secondRowName = secondEntityTable.LogicalName + "id2";
}

var connectionTable = new Table
{
Type = TableType.ConnectionTable,
Expand All @@ -428,28 +452,39 @@ public static List<Relationship> ParseRelationships(List<Module> modules, List<T
SetName = intersectEntityName + "s",
Rows = {
new TableRow(intersectEntityName + "id", RowType.Primarykey),
new TableRow(firstEntityTable.LogicalName + "id", RowType.Lookup),
new TableRow(secondEntityTable.LogicalName + "id", RowType.Lookup),
new TableRow(firstRowName, RowType.Lookup),
new TableRow(secondRowName, RowType.Lookup),
}
};


EntityTables.Add(connectionTable);

var firstToMid = new Relationship(relationship.Attribute("Name").Value,
// The second leg also needs its own name: both legs otherwise carry the
// relationship name, and EDMX renders the intersect side as
// NavigationProperty Name="{relationship.Name}" plus a matching Partner and
// NavigationPropertyBinding Path, so a self-referencing N:N emits each of
// them twice. Suffixed positionally for the same reason as the column above:
// the real per-side names live in metadata and are author-chosen.
var relationshipName = relationship.Attribute("Name").Value;
var isSelfReferencing = string.Equals(
firstEntityTable.LogicalName, secondEntityTable.LogicalName, StringComparison.OrdinalIgnoreCase);
var secondRelationshipName = isSelfReferencing ? relationshipName + "_2" : relationshipName;

var firstToMid = new Relationship(relationshipName,
"ManyToOne",
firstEntityTable,
firstEntityTable.Rows.FirstOrDefault(x => x.RowType == RowType.Primarykey),
connectionTable,
connectionTable.Rows.FirstOrDefault(x => x.Name == firstEntityTable.LogicalName + "id"));
connectionTable.Rows.FirstOrDefault(x => x.Name == firstRowName));


var secondToMid = new Relationship(relationship.Attribute("Name").Value,
var secondToMid = new Relationship(secondRelationshipName,
"ManyToOne",
secondEntityTable,
secondEntityTable.Rows.FirstOrDefault(x => x.RowType == RowType.Primarykey),
connectionTable,
connectionTable.Rows.FirstOrDefault(x => x.Name == secondEntityTable.LogicalName + "id"));
connectionTable.Rows.FirstOrDefault(x => x.Name == secondRowName));

EntityRelationships.Add(firstToMid);
EntityRelationships.Add(secondToMid);
Expand Down Expand Up @@ -489,7 +524,7 @@ public static List<Relationship> ParseRelationships(List<Module> modules, List<T
rightSideTable,
rightSideTable.Rows.FirstOrDefault(x => x.RowType == RowType.Primarykey));

if (EntityRelationships.FirstOrDefault(x => x.LeftSideTable == entityRelationship.LeftSideTable && x.RighSideTable == entityRelationship.RighSideTable) == default)
if (EntityRelationships.FirstOrDefault(x => x.LeftSideTable == entityRelationship.LeftSideTable && x.LeftSideRow == entityRelationship.LeftSideRow && x.RighSideTable == entityRelationship.RighSideTable) == default)
{
EntityRelationships.Add(entityRelationship);
}
Expand Down
23 changes: 19 additions & 4 deletions src/TALXIS.CLI.Features.Data/DataModelConverter/Model/Module.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,15 @@ public class Module
{
public Module()
{
var random = new Random();
Colorhex = string.Format("#{0:X6}", random.Next(0x1000000));
Colorhex = ColourFor(ModuleName);
}

public Module(string module, XDocument xml)
{
ModuleName = module;
XmlDoc = xml;

var random = new Random();
Colorhex = string.Format("#{0:X6}", random.Next(0x1000000));
Colorhex = ColourFor(ModuleName);

entities = XmlDoc.Descendants().Where(x => x.Name == "Entity").ToList();
relationships = XmlDoc.Descendants().Where(x => x.Name == "EntityRelationship").ToList();
Expand All @@ -36,4 +34,21 @@ public Module(string module, XDocument xml)
public List<XElement> optionsets = [];

public string Colorhex { get; }

/// <summary>
/// Derives the module colour from its name so the same input always converts to the
/// same bytes. A random colour made every conversion a spurious diff, which meant a
/// generated diagram could not be committed or compared across a model change.
/// FNV-1a rather than string.GetHashCode, which is randomised per process on .NET Core.
/// </summary>
private static string ColourFor(string moduleName)
{
uint hash = 2166136261;
foreach (var c in moduleName ?? string.Empty)
{
hash ^= c;
hash *= 16777619;
}
return string.Format("#{0:X6}", hash & 0xFFFFFF);
}
}
Loading