feat: witness Geometry Nodes bundle round-trip - #128
Merged
Conversation
5.x RNA is NodeCombineBundle; 4.5 skips via min_version 5.0. Count-only is not enough — bbox and named attribute are the second and third axes. Standing scalar-second-axis rule added to the example prompt. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/gn-bundle-roundtrip/: Combine / Separate Bundle item-name round-trip on 5.x (NodeCombineBundle, notGeometryNodeCombineBundle). Asserts evaluated 8/6 plus x-extent[0.5, 2.5]plus POINTbundle_mark=0.314159. Count-only is a cube that never entered the bundle.min_versionskip: 4.5 printsSMOKE_SKIP: Bundles require Blender 5.0+, exit 77; harness classifies SKIP (not PASS). 5.2 runs and passes.docs/new-example-prompt.md: when the primary assertion is a scalar, check whether a broken construction can produce it; if so add a second axis. Worked example:gn-zone-iterate--no-offset.Type
feat— new skill / rule / snippet / template / example (minor bump)fix— correction to existing content or a broken contract (patch bump)docs/chore/ci/refactor— no release;release.ymlstill runs and should exit without a tagSquash-merge subject:
feat: witness Geometry Nodes bundle round-tripEvidence
Axes — inspection of design, proven by the falsify table
Primary scalar: vert/face count 8/6. Broken construction produces it:
--bypass(cube never enters the bundle) is still 8/6. Second axis: unpacked Scale/Offset bboxx ∈ [0.5, 2.5]. Third: unpacked Float stored as POINTbundle_mark. A fully hardcoded Transform that never uses a bundle could still fake bbox+attr (same class as Instance-on-Points faking a Repeat); the falsifiers that break this construction are bypass / mismatch / wrong packed scale / legacy RNA.No gallery still. One cube plus an invisible attribute is not thumbnail-legible as a bundle contract.
Check-only — live-run-proven
Windows
.scratch/blender-5.2.1-windows-x64/blender.exe5.2.1 LTS9e2066aef7ef;.scratch/blender-5.1.2-windows-x64/blender.exe5.1.2ec6e62d40fa9;.scratch/blender-4.5.11-windows-x64/blender.exe4.5.11 LTS4db51e9d1e1e.xmin=0.5000 xmax=2.5000 mark=0.314159 pairing=okSMOKE_SKIP: Bundles require Blender 5.0+--series 5.2 --min-version 5.0[PASS] gn-bundle-roundtrip--series 4.5 --min-version 5.0[SKIP] gn-bundle-roundtrip: Bundles require Blender 5.0+min_version[FAIL] skipped with no --min-version (unexpected)Skip honesty — live-run-proven
--force-runon 4.5.11: exit 1,RuntimeError: Node type NodeCombineBundle undefined. The skip is not hiding a pass of the 5.x RNA.Related (not the skip path, same machine): 4.5 does have
GeometryNodeCombineBundle. Flaguse_bundle_and_closure_nodesdefault off evaluates 0 verts. Flag on hits the same closed form 8/6[0.5, 2.5]mark=0.314159. Skip is the official unflagged 5.0+ contract, not “bundles cannot exist on 4.5”.Falsify on 5.2.1 — live-run-proven
[0.5, 2.5], mark 0.314159--bypass[-0.5, 0.5], no attr--mismatchGeomvs CombineMesh)--pack-scale 1[1.0, 2.0]--legacy-rnaGeometryNodeCombineBundle undefinedGenerated HTML / contact sheet
Not applicable — no
gallery.jsonrow, no still, nobuild_gallery.py.Release-owned fields — do not hand-edit
VERSION,CHANGELOG.md, CLAUDE.md**Version:**, ROADMAP.md**Current:**, plugin.json"version". Left at 0.50.0.Test plan
blender-smoke5.2 LTS:gn-bundle-roundtripPASS, no SKIP on that rowblender-smoke4.5 LTS:gn-bundle-roundtripSKIP with reason, counted separately from passes, job still green (other examples PASS)validate-counts/validate-manifestgreen (49 examples)release.ymldecision line; expectRELEASE (bump=minor)→ v0.51.0Made with Cursor