feat: witness exit_pre via post-exit sidecar - #129
Merged
Conversation
The handler writes the sidecar as Blender dies; the catalog runner now forwards expect_sidecar so CI actually asserts it. 4.5 skips at min_version 5.1. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/exit-pre-sidecar/:bpy.app.handlers.exit_prewrites `` as Blender dies.maindoes not write the file.expect_sidecar/sidecar_contains(was canary-only). Without that, CI would have been a vacuous PASS.min_version5.1. No gallery still.Type
feat— new skill / rule / snippet / template / example (minor bump)Squash-merge subject:
feat: witness exit_pre via post-exit sidecarEvidence
Harness contents vs existence — live-run-proven
sidecar_okintests/smoke/protocol.pychecks existence, non-empty, and optional substring. Catalog row:sidecar_contains: exit_pre-ok.[PASS]exit_pre-ok--silent-handler[FAIL] missing post-exit sidecar--no-handler[FAIL] missing post-exit sidecar--wrong-text[FAIL] sidecar missing expected text 'exit_pre-ok'nope--write-in-main[FAIL] sidecar missing expected text 'exit_pre-ok'from-main--atexit-insteadatexit-ok(existence-only would have been a false pass)--no-handlerprovesmaindoes not write the sidecar.--write-in-main/--atexit-insteadprove the content check, so a clean-exit write that is notexit_preis red.Binaries: Win
.scratch/blender-5.2.1-windows-x64/blender.exe5.2.1 LTS9e2066aef7ef;blender-5.1.2-windows-x645.1.2ec6e62d40fa9;blender-4.5.11-windows-x644.5.11 LTS4db51e9d1e1e.Skip / force-run — live-run-proven
--min-version 5.1 --expect-sidecar[PASS]--series 4.5 --min-version 5.1[SKIP] exit_pre requires Blender 5.1+(no sidecar required)[FAIL] skipped with no --min-version (unexpected)--force-run(direct blender)AttributeError: 'bpy.app.handlers' object has no attribute 'exit_pre'Gallery
None. No geometry.
Backlog (ROADMAP, not this PR's code beyond the bullet)
Falsification flags for Phases 6–9 were local-Windows only. Alongside inverted-canary marker-text.
Release-owned fields — do not hand-edit
Left at 0.51.0.
Test plan
exit-pre-sidecarPASS (sidecar asserted)exit-pre-sidecarSKIP with reason, counted separatelyrelease.ymlon the merge SHA; expectRELEASE (bump=minor)→ v0.52.0Made with Cursor