Move service API from TactilityKernel to service-module - #604
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a dedicated service module with service contracts, path APIs, implementations, symbol exports, and dependency metadata. Updates project, SDK, GPS, Tactility, firmware, and kernel integration to use the module. Adds ServiceModuleTests with FreeRTOS and Doctest integration. Updates service-related test includes and broadens build-directory ignore patterns. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
🧹 Nitpick comments (3)
buildsim-posix/Tests/TactilityKernel/TactilityKernelTests (1)
1-1511: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueBinary build artifact, not reviewable source.
This file is a compiled ELF executable rendered as text, not source code. No meaningful code review can be performed on it.
buildsim-posix/Tests/Testing/Temporary/CTestCostData.txt (1)
1-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winKeep runtime-generated CTest cost data out of the PR.
These timings are environment-specific and create stale, non-reproducible build metadata. Regenerate them in the build directory when needed.
Tests/service-module/LICENSE-Apache-2.0.md (1)
7-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMake the license file Markdown-lint compliant or exempt it.
The new file triggers MD001/MD003 because it mixes setext and ATX headings and skips heading levels. Normalize the headings or add a targeted lint exclusion for license files.
Also applies to: 63-63, 71-71, 86-86, 120-120, 129-129, 136-136, 147-147, 159-159, 172-172
Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9094185e-ca4c-4b5e-a6c9-f8b4a483fc72
⛔ Files ignored due to path filters (11)
buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_bignum.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_bignum_core.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_bignum_mod.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_bignum_mod_raw.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_ecp.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_generate_key.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_low_hash.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_not_supported.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_op_fail.generated.datais excluded by!**/*.generated.*buildsim-posix/Testing/Temporary/LastTest.logis excluded by!**/*.logbuildsim-posix/Tests/Testing/Temporary/LastTest.logis excluded by!**/*.log
📒 Files selected for processing (105)
Buildscripts/release-sdk.pyCMakeLists.txtModules/gps-module/CMakeLists.txtModules/gps-module/source/gps_settings.cppModules/service-module/CMakeLists.txtModules/service-module/LICENSE-Apache-2.0.mdModules/service-module/devicetree.yamlModules/service-module/include/service/instance.hModules/service-module/include/service/manager.hModules/service-module/include/service/manifest.hModules/service-module/include/service/paths.hModules/service-module/source/instance.cppModules/service-module/source/manager.cppModules/service-module/source/paths.cppModules/service-module/source/symbols.cppTactility/CMakeLists.txtTactility/Include/Tactility/service/Service.hTactility/Include/Tactility/service/ServiceContext.hTactility/Include/Tactility/service/ServicePaths.hTactility/Source/service/ServiceContext.cppTactility/Source/service/ServiceRegistration.cppTactilityKernel/source/symbols.cTests/CMakeLists.txtTests/service-module/CMakeLists.txtTests/service-module/LICENSE-Apache-2.0.mdTests/service-module/Source/Main.cppTests/service-module/Source/ServicePathsTest.cppTests/service-module/Source/ServiceTest.cppbuildsim-posix/.ninja_depsbuildsim-posix/.ninja_logbuildsim-posix/Devices/simulator/cmake_install.cmakebuildsim-posix/Drivers/gps-generic-module/cmake_install.cmakebuildsim-posix/Drivers/gps-meshtastic-module/cmake_install.cmakebuildsim-posix/Firmware/cmake_install.cmakebuildsim-posix/Libraries/FreeRTOS-Kernel/cmake_install.cmakebuildsim-posix/Libraries/FreeRTOS-Kernel/libfreertos_kernel.abuildsim-posix/Libraries/FreeRTOS-Kernel/portable/cmake_install.cmakebuildsim-posix/Libraries/FreeRTOS-Kernel/portable/libfreertos_kernel_port.abuildsim-posix/Libraries/QRCode/cmake_install.cmakebuildsim-posix/Libraries/SDL/SDL2.specbuildsim-posix/Libraries/SDL/SDL_config.h.intermediatebuildsim-posix/Libraries/SDL/cmake_install.cmakebuildsim-posix/Libraries/SDL/cmake_uninstall.cmakebuildsim-posix/Libraries/SDL/include-config-/SDL2/SDL_config.hbuildsim-posix/Libraries/SDL/include/SDL2/SDL_revision.hbuildsim-posix/Libraries/SDL/sdl2-configbuildsim-posix/Libraries/SDL/sdl2.pcbuildsim-posix/Libraries/cJSON/cmake_install.cmakebuildsim-posix/Libraries/lv_screenshot/cmake_install.cmakebuildsim-posix/Libraries/lvgl/cmake_install.cmakebuildsim-posix/Libraries/lvgl/lv_version.hbuildsim-posix/Libraries/lvgl/lvgl.pcbuildsim-posix/Libraries/mbedtls/3rdparty/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/3rdparty/everest/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/3rdparty/p256-m/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/DartConfiguration.tclbuildsim-posix/Libraries/mbedtls/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/include/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/include/mbedtlsbuildsim-posix/Libraries/mbedtls/include/psabuildsim-posix/Libraries/mbedtls/library/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/library/error.cbuildsim-posix/Libraries/mbedtls/library/psa_crypto_driver_wrappers_no_static.cbuildsim-posix/Libraries/mbedtls/library/ssl_debug_helpers_generated.cbuildsim-posix/Libraries/mbedtls/library/version_features.cbuildsim-posix/Libraries/mbedtls/programs/psa/psa_constant_names_generated.cbuildsim-posix/Libraries/mbedtls/programs/test/query_config.cbuildsim-posix/Libraries/mbedtls/scriptsbuildsim-posix/Libraries/mbedtls/tests/Descriptions.txtbuildsim-posix/Libraries/mbedtls/tests/compat.shbuildsim-posix/Libraries/mbedtls/tests/context-info.shbuildsim-posix/Libraries/mbedtls/tests/data_filesbuildsim-posix/Libraries/mbedtls/tests/opt-testcasesbuildsim-posix/Libraries/mbedtls/tests/scriptsbuildsim-posix/Libraries/mbedtls/tests/ssl-opt.shbuildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_storage_format.current.databuildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_storage_format.v0.databuildsim-posix/Libraries/minitar/cmake_install.cmakebuildsim-posix/Libraries/minmea/cmake_install.cmakebuildsim-posix/Modules/crypt-module/cmake_install.cmakebuildsim-posix/Modules/gps-module/cmake_install.cmakebuildsim-posix/Modules/lvgl-module/cmake_install.cmakebuildsim-posix/Modules/service-module/cmake_install.cmakebuildsim-posix/Platforms/platform-posix/cmake_install.cmakebuildsim-posix/Tactility/cmake_install.cmakebuildsim-posix/TactilityFreeRtos/cmake_install.cmakebuildsim-posix/TactilityKernel/cmake_install.cmakebuildsim-posix/Testing/Temporary/CTestCostData.txtbuildsim-posix/Tests/CTestTestfile.cmakebuildsim-posix/Tests/Tactility/CTestTestfile.cmakebuildsim-posix/Tests/Tactility/cmake_install.cmakebuildsim-posix/Tests/TactilityFreeRtos/CTestTestfile.cmakebuildsim-posix/Tests/TactilityFreeRtos/cmake_install.cmakebuildsim-posix/Tests/TactilityKernel/CTestTestfile.cmakebuildsim-posix/Tests/TactilityKernel/TactilityKernelTestsbuildsim-posix/Tests/TactilityKernel/cmake_install.cmakebuildsim-posix/Tests/Testing/Temporary/CTestCostData.txtbuildsim-posix/Tests/cmake_install.cmakebuildsim-posix/Tests/crypt-module/CTestTestfile.cmakebuildsim-posix/Tests/crypt-module/cmake_install.cmakebuildsim-posix/Tests/service-module/CTestTestfile.cmakebuildsim-posix/Tests/service-module/ServiceModuleTestsbuildsim-posix/Tests/service-module/cmake_install.cmakebuildsim-posix/build.ninjabuildsim-posix/cmake_install.cmake
💤 Files with no reviewable changes (1)
- TactilityKernel/source/symbols.c
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 12
🧹 Nitpick comments (3)
buildsim-posix/Tests/TactilityKernel/TactilityKernelTests (1)
1-1511: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueBinary build artifact, not reviewable source.
This file is a compiled ELF executable rendered as text, not source code. No meaningful code review can be performed on it.
buildsim-posix/Tests/Testing/Temporary/CTestCostData.txt (1)
1-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winKeep runtime-generated CTest cost data out of the PR.
These timings are environment-specific and create stale, non-reproducible build metadata. Regenerate them in the build directory when needed.
Tests/service-module/LICENSE-Apache-2.0.md (1)
7-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMake the license file Markdown-lint compliant or exempt it.
The new file triggers MD001/MD003 because it mixes setext and ATX headings and skips heading levels. Normalize the headings or add a targeted lint exclusion for license files.
Also applies to: 63-63, 71-71, 86-86, 120-120, 129-129, 136-136, 147-147, 159-159, 172-172
Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9094185e-ca4c-4b5e-a6c9-f8b4a483fc72
⛔ Files ignored due to path filters (11)
buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_bignum.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_bignum_core.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_bignum_mod.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_bignum_mod_raw.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_ecp.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_generate_key.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_low_hash.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_not_supported.generated.datais excluded by!**/*.generated.*buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_op_fail.generated.datais excluded by!**/*.generated.*buildsim-posix/Testing/Temporary/LastTest.logis excluded by!**/*.logbuildsim-posix/Tests/Testing/Temporary/LastTest.logis excluded by!**/*.log
📒 Files selected for processing (105)
Buildscripts/release-sdk.pyCMakeLists.txtModules/gps-module/CMakeLists.txtModules/gps-module/source/gps_settings.cppModules/service-module/CMakeLists.txtModules/service-module/LICENSE-Apache-2.0.mdModules/service-module/devicetree.yamlModules/service-module/include/service/instance.hModules/service-module/include/service/manager.hModules/service-module/include/service/manifest.hModules/service-module/include/service/paths.hModules/service-module/source/instance.cppModules/service-module/source/manager.cppModules/service-module/source/paths.cppModules/service-module/source/symbols.cppTactility/CMakeLists.txtTactility/Include/Tactility/service/Service.hTactility/Include/Tactility/service/ServiceContext.hTactility/Include/Tactility/service/ServicePaths.hTactility/Source/service/ServiceContext.cppTactility/Source/service/ServiceRegistration.cppTactilityKernel/source/symbols.cTests/CMakeLists.txtTests/service-module/CMakeLists.txtTests/service-module/LICENSE-Apache-2.0.mdTests/service-module/Source/Main.cppTests/service-module/Source/ServicePathsTest.cppTests/service-module/Source/ServiceTest.cppbuildsim-posix/.ninja_depsbuildsim-posix/.ninja_logbuildsim-posix/Devices/simulator/cmake_install.cmakebuildsim-posix/Drivers/gps-generic-module/cmake_install.cmakebuildsim-posix/Drivers/gps-meshtastic-module/cmake_install.cmakebuildsim-posix/Firmware/cmake_install.cmakebuildsim-posix/Libraries/FreeRTOS-Kernel/cmake_install.cmakebuildsim-posix/Libraries/FreeRTOS-Kernel/libfreertos_kernel.abuildsim-posix/Libraries/FreeRTOS-Kernel/portable/cmake_install.cmakebuildsim-posix/Libraries/FreeRTOS-Kernel/portable/libfreertos_kernel_port.abuildsim-posix/Libraries/QRCode/cmake_install.cmakebuildsim-posix/Libraries/SDL/SDL2.specbuildsim-posix/Libraries/SDL/SDL_config.h.intermediatebuildsim-posix/Libraries/SDL/cmake_install.cmakebuildsim-posix/Libraries/SDL/cmake_uninstall.cmakebuildsim-posix/Libraries/SDL/include-config-/SDL2/SDL_config.hbuildsim-posix/Libraries/SDL/include/SDL2/SDL_revision.hbuildsim-posix/Libraries/SDL/sdl2-configbuildsim-posix/Libraries/SDL/sdl2.pcbuildsim-posix/Libraries/cJSON/cmake_install.cmakebuildsim-posix/Libraries/lv_screenshot/cmake_install.cmakebuildsim-posix/Libraries/lvgl/cmake_install.cmakebuildsim-posix/Libraries/lvgl/lv_version.hbuildsim-posix/Libraries/lvgl/lvgl.pcbuildsim-posix/Libraries/mbedtls/3rdparty/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/3rdparty/everest/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/3rdparty/p256-m/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/DartConfiguration.tclbuildsim-posix/Libraries/mbedtls/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/include/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/include/mbedtlsbuildsim-posix/Libraries/mbedtls/include/psabuildsim-posix/Libraries/mbedtls/library/cmake_install.cmakebuildsim-posix/Libraries/mbedtls/library/error.cbuildsim-posix/Libraries/mbedtls/library/psa_crypto_driver_wrappers_no_static.cbuildsim-posix/Libraries/mbedtls/library/ssl_debug_helpers_generated.cbuildsim-posix/Libraries/mbedtls/library/version_features.cbuildsim-posix/Libraries/mbedtls/programs/psa/psa_constant_names_generated.cbuildsim-posix/Libraries/mbedtls/programs/test/query_config.cbuildsim-posix/Libraries/mbedtls/scriptsbuildsim-posix/Libraries/mbedtls/tests/Descriptions.txtbuildsim-posix/Libraries/mbedtls/tests/compat.shbuildsim-posix/Libraries/mbedtls/tests/context-info.shbuildsim-posix/Libraries/mbedtls/tests/data_filesbuildsim-posix/Libraries/mbedtls/tests/opt-testcasesbuildsim-posix/Libraries/mbedtls/tests/scriptsbuildsim-posix/Libraries/mbedtls/tests/ssl-opt.shbuildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_storage_format.current.databuildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_storage_format.v0.databuildsim-posix/Libraries/minitar/cmake_install.cmakebuildsim-posix/Libraries/minmea/cmake_install.cmakebuildsim-posix/Modules/crypt-module/cmake_install.cmakebuildsim-posix/Modules/gps-module/cmake_install.cmakebuildsim-posix/Modules/lvgl-module/cmake_install.cmakebuildsim-posix/Modules/service-module/cmake_install.cmakebuildsim-posix/Platforms/platform-posix/cmake_install.cmakebuildsim-posix/Tactility/cmake_install.cmakebuildsim-posix/TactilityFreeRtos/cmake_install.cmakebuildsim-posix/TactilityKernel/cmake_install.cmakebuildsim-posix/Testing/Temporary/CTestCostData.txtbuildsim-posix/Tests/CTestTestfile.cmakebuildsim-posix/Tests/Tactility/CTestTestfile.cmakebuildsim-posix/Tests/Tactility/cmake_install.cmakebuildsim-posix/Tests/TactilityFreeRtos/CTestTestfile.cmakebuildsim-posix/Tests/TactilityFreeRtos/cmake_install.cmakebuildsim-posix/Tests/TactilityKernel/CTestTestfile.cmakebuildsim-posix/Tests/TactilityKernel/TactilityKernelTestsbuildsim-posix/Tests/TactilityKernel/cmake_install.cmakebuildsim-posix/Tests/Testing/Temporary/CTestCostData.txtbuildsim-posix/Tests/cmake_install.cmakebuildsim-posix/Tests/crypt-module/CTestTestfile.cmakebuildsim-posix/Tests/crypt-module/cmake_install.cmakebuildsim-posix/Tests/service-module/CTestTestfile.cmakebuildsim-posix/Tests/service-module/ServiceModuleTestsbuildsim-posix/Tests/service-module/cmake_install.cmakebuildsim-posix/build.ninjabuildsim-posix/cmake_install.cmake
💤 Files with no reviewable changes (1)
- TactilityKernel/source/symbols.c
🛑 Comments failed to post (10)
buildsim-posix/.ninja_deps (1)
2-103: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Remove generated
buildsim-posixartifacts from the PR.These files contain machine-specific Ninja/CMake state, including
/home/ken/Projects/Tactilitypaths and generated timestamps/hashes. They are not portable or reproducible across developers and CI. Ignore the build directory and regenerate it from the source CMake files.
buildsim-posix/.ninja_deps#L2-L103: remove the author-local dependency database.buildsim-posix/.ninja_log#L1-L103: remove the machine-specific Ninja log.buildsim-posix/Devices/simulator/cmake_install.cmake#L1-L50: regenerate the simulator install script.buildsim-posix/Drivers/gps-generic-module/cmake_install.cmake#L1-L50: regenerate the GPS generic install script.buildsim-posix/Drivers/gps-meshtastic-module/cmake_install.cmake#L1-L50: regenerate the Meshtastic GPS install script.buildsim-posix/Modules/gps-module/cmake_install.cmake#L1-L50: regenerate the GPS module install script.buildsim-posix/Modules/lvgl-module/cmake_install.cmake#L1-L50: regenerate the LVGL module install script.buildsim-posix/Modules/service-module/cmake_install.cmake#L1-L50: regenerate the service-module install script.buildsim-posix/Platforms/platform-posix/cmake_install.cmake#L1-L50: regenerate the POSIX platform install script.buildsim-posix/Tactility/cmake_install.cmake#L1-L50: regenerate the Tactility install script.buildsim-posix/TactilityFreeRtos/cmake_install.cmake#L1-L50: regenerate the FreeRTOS install script.📍 Affects 11 files
buildsim-posix/.ninja_deps#L2-L103(this comment)buildsim-posix/.ninja_log#L1-L103buildsim-posix/Devices/simulator/cmake_install.cmake#L1-L50buildsim-posix/Drivers/gps-generic-module/cmake_install.cmake#L1-L50buildsim-posix/Drivers/gps-meshtastic-module/cmake_install.cmake#L1-L50buildsim-posix/Modules/gps-module/cmake_install.cmake#L1-L50buildsim-posix/Modules/lvgl-module/cmake_install.cmake#L1-L50buildsim-posix/Modules/service-module/cmake_install.cmake#L1-L50buildsim-posix/Platforms/platform-posix/cmake_install.cmake#L1-L50buildsim-posix/Tactility/cmake_install.cmake#L1-L50buildsim-posix/TactilityFreeRtos/cmake_install.cmake#L1-L50buildsim-posix/cmake_install.cmake (1)
45-153: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Remove generated
buildsim-posixoutput from the PR.These generated scripts hard-code
/home/ken/Projects/Tactility; a different checkout cannot run the recorded install or CTest commands. Remove generated build artifacts, add the build directory to ignore rules, and regenerate it locally/CI instead.buildsim-posix/Firmware/cmake_install.cmake (1)
1-50: 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
Remove generated
buildsim-posixoutput from the PR.These files hard-code the author’s workspace and include host-built archives, so checked-out CTest/install metadata is invalid elsewhere and the repository gains non-reproducible binaries. Add
buildsim-posix/to ignore rules; retain the source CMake changes only.
buildsim-posix/Firmware/cmake_install.cmake#L1-L50: remove generated install metadata.buildsim-posix/Libraries/FreeRTOS-Kernel/cmake_install.cmake#L1-L55: remove generated install metadata.buildsim-posix/Libraries/FreeRTOS-Kernel/libfreertos_kernel.a#L1-L358: remove the compiled archive.buildsim-posix/Libraries/FreeRTOS-Kernel/portable/cmake_install.cmake#L1-L50: remove generated install metadata.buildsim-posix/Libraries/FreeRTOS-Kernel/portable/libfreertos_kernel_port.a#L1-L35: remove the compiled archive.buildsim-posix/TactilityKernel/cmake_install.cmake#L1-L50: remove generated install metadata.buildsim-posix/Testing/Temporary/CTestCostData.txt#L1-L2: remove transient CTest state.buildsim-posix/Tests/CTestTestfile.cmake#L1-L11: remove path-bound generated test metadata.buildsim-posix/Tests/Tactility/CTestTestfile.cmake#L1-L8: remove the path-bound test registration.buildsim-posix/Tests/Tactility/cmake_install.cmake#L1-L50: remove generated install metadata.buildsim-posix/Tests/TactilityFreeRtos/CTestTestfile.cmake#L1-L8: remove the path-bound test registration.📍 Affects 11 files
buildsim-posix/Firmware/cmake_install.cmake#L1-L50(this comment)buildsim-posix/Libraries/FreeRTOS-Kernel/cmake_install.cmake#L1-L55buildsim-posix/Libraries/FreeRTOS-Kernel/libfreertos_kernel.a#L1-L358buildsim-posix/Libraries/FreeRTOS-Kernel/portable/cmake_install.cmake#L1-L50buildsim-posix/Libraries/FreeRTOS-Kernel/portable/libfreertos_kernel_port.a#L1-L35buildsim-posix/TactilityKernel/cmake_install.cmake#L1-L50buildsim-posix/Testing/Temporary/CTestCostData.txt#L1-L2buildsim-posix/Tests/CTestTestfile.cmake#L1-L11buildsim-posix/Tests/Tactility/CTestTestfile.cmake#L1-L8buildsim-posix/Tests/Tactility/cmake_install.cmake#L1-L50buildsim-posix/Tests/TactilityFreeRtos/CTestTestfile.cmake#L1-L8buildsim-posix/Libraries/mbedtls/3rdparty/p256-m/cmake_install.cmake (1)
46-46: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Fix the malformed p256-m header source path.
This passes
/p256-m/:/p256-mas one path, which does not exist;cmake --installwill fail when installing these headers. Fix the upstreaminstall()declaration and regenerate this file.buildsim-posix/Libraries/mbedtls/cmake_install.cmake (1)
47-49: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Remove the machine-specific generated POSIX build artifacts. The CMake scripts embed
/home/ken/...source/build paths, and the link entries target the same absolute checkout. This makes installation and compilation fail in other checkouts.
- buildsim-posix/Libraries/mbedtls/cmake_install.cmake#L47-L49: regenerate install metadata per checkout.
- buildsim-posix/Libraries/mbedtls/include/cmake_install.cmake#L46-L47: remove absolute header paths.
- buildsim-posix/Libraries/mbedtls/include/mbedtls#L1-L1: use a relative link or regenerate the build tree.
- buildsim-posix/Libraries/mbedtls/include/psa#L1-L1: use a relative link or regenerate the build tree.
- buildsim-posix/Libraries/mbedtls/library/cmake_install.cmake#L46-L46: remove the absolute archive path.
- buildsim-posix/Libraries/mbedtls/library/error.c#L1-L1: use a relocatable source link.
- buildsim-posix/Libraries/mbedtls/library/psa_crypto_driver_wrappers_no_static.c#L1-L1: use a relocatable source link.
- buildsim-posix/Libraries/mbedtls/library/ssl_debug_helpers_generated.c#L1-L1: use a relocatable source link.
- buildsim-posix/Libraries/mbedtls/library/version_features.c#L1-L1: use a relocatable source link.
- buildsim-posix/Libraries/mbedtls/programs/psa/psa_constant_names_generated.c#L1-L1: use a relocatable source link.
📍 Affects 10 files
buildsim-posix/Libraries/mbedtls/cmake_install.cmake#L47-L49(this comment)buildsim-posix/Libraries/mbedtls/include/cmake_install.cmake#L46-L47buildsim-posix/Libraries/mbedtls/include/mbedtls#L1-L1buildsim-posix/Libraries/mbedtls/include/psa#L1-L1buildsim-posix/Libraries/mbedtls/library/cmake_install.cmake#L46-L46buildsim-posix/Libraries/mbedtls/library/error.c#L1-L1buildsim-posix/Libraries/mbedtls/library/psa_crypto_driver_wrappers_no_static.c#L1-L1buildsim-posix/Libraries/mbedtls/library/ssl_debug_helpers_generated.c#L1-L1buildsim-posix/Libraries/mbedtls/library/version_features.c#L1-L1buildsim-posix/Libraries/mbedtls/programs/psa/psa_constant_names_generated.c#L1-L1buildsim-posix/Libraries/mbedtls/programs/test/query_config.c (1)
1-1: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make the generated Mbed TLS links relocatable.
All seven entries point to
/home/ken/Projects/Tactility, so Mbed TLS builds and tests will break in clean checkouts and CI.
buildsim-posix/Libraries/mbedtls/programs/test/query_config.c#L1-L1: use a relative link or regenerate the build tree.buildsim-posix/Libraries/mbedtls/scripts#L1-L1: use a relative link or regenerate the build tree.buildsim-posix/Libraries/mbedtls/tests/Descriptions.txt#L1-L1: use a relative link or regenerate the build tree.buildsim-posix/Libraries/mbedtls/tests/compat.sh#L1-L1: use a relative link or regenerate the build tree.buildsim-posix/Libraries/mbedtls/tests/context-info.sh#L1-L1: use a relative link or regenerate the build tree.buildsim-posix/Libraries/mbedtls/tests/data_files#L1-L1: use a relative link or regenerate the build tree.buildsim-posix/Libraries/mbedtls/tests/opt-testcases#L1-L1: use a relative link or regenerate the build tree.📍 Affects 7 files
buildsim-posix/Libraries/mbedtls/programs/test/query_config.c#L1-L1(this comment)buildsim-posix/Libraries/mbedtls/scripts#L1-L1buildsim-posix/Libraries/mbedtls/tests/Descriptions.txt#L1-L1buildsim-posix/Libraries/mbedtls/tests/compat.sh#L1-L1buildsim-posix/Libraries/mbedtls/tests/context-info.sh#L1-L1buildsim-posix/Libraries/mbedtls/tests/data_files#L1-L1buildsim-posix/Libraries/mbedtls/tests/opt-testcases#L1-L1buildsim-posix/Libraries/minitar/cmake_install.cmake (1)
1-50: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Local out-of-source build directory (
buildsim-posix/) appears to have been committed by accident.All of these are CMake/SDL-generated build outputs or dangling symlinks, not source files, and several hardcode the author's local absolute path (
/home/ken/Projects/Tactility/...). Committing them bloats the repo, will conflict on every future regeneration, and the mbedtls entries will be broken symlinks on any other checkout. This pattern repeats across the entirebuildsim-posix/cohort of this PR (80+ files per the PR objectives), not just these 11. Recommend removingbuildsim-posix/from version control and adding it to.gitignore.
buildsim-posix/Libraries/minitar/cmake_install.cmake: remove from version control; confirmed live build output (included by the top-level generatedcmake_install.cmake).buildsim-posix/Libraries/SDL/cmake_uninstall.cmake: remove; regenerated by SDL'suninstalltarget viaconfigure_file.buildsim-posix/Libraries/SDL/include-config-/SDL2/SDL_config.h: remove; regenerated fromSDL_config.h.inon every configure.buildsim-posix/Libraries/SDL/include/SDL2/SDL_revision.h: remove; tied to the exact vendored SDL git-describe state, will drift immediately.buildsim-posix/Libraries/SDL/sdl2-config: remove; regenerated fromsdl2-config.in.buildsim-posix/Libraries/mbedtls/tests/scripts: remove; symlink target is an absolute local path, dangling elsewhere.buildsim-posix/Libraries/mbedtls/tests/ssl-opt.sh: remove; same dangling-symlink issue.buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_storage_format.current.data: remove; same dangling-symlink issue.buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_storage_format.v0.data: remove; same dangling-symlink issue.buildsim-posix/Libraries/minmea/cmake_install.cmake: remove; regenerated CMake install script with hardcoded local path.buildsim-posix/Modules/crypt-module/cmake_install.cmake: remove; regenerated CMake install script with hardcoded local path.🧹 Suggested .gitignore addition
+buildsim-posix/📍 Affects 11 files
buildsim-posix/Libraries/minitar/cmake_install.cmake#L1-L50(this comment)buildsim-posix/Libraries/SDL/cmake_uninstall.cmake#L1-L18buildsim-posix/Libraries/SDL/include-config-/SDL2/SDL_config.h#L1-L571buildsim-posix/Libraries/SDL/include/SDL2/SDL_revision.h#L1-L8buildsim-posix/Libraries/SDL/sdl2-config#L1-L65buildsim-posix/Libraries/mbedtls/tests/scripts#L1-L1buildsim-posix/Libraries/mbedtls/tests/ssl-opt.sh#L1-L1buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_storage_format.current.data#L1-L1buildsim-posix/Libraries/mbedtls/tests/suites/test_suite_psa_crypto_storage_format.v0.data#L1-L1buildsim-posix/Libraries/minmea/cmake_install.cmake#L1-L50buildsim-posix/Modules/crypt-module/cmake_install.cmake#L1-L50buildsim-posix/Libraries/QRCode/cmake_install.cmake (1)
48-49: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not commit machine-specific CMake install output.
Both generated scripts embed
/home/ken/Projects/Tactility; installation from another checkout will use invalid paths.
buildsim-posix/Libraries/QRCode/cmake_install.cmake#L48-L49: regenerate this script per build or remove the checked-in artifact.buildsim-posix/Libraries/SDL/cmake_install.cmake#L48-L49: regenerate this script per build or remove the checked-in artifact.📍 Affects 2 files
buildsim-posix/Libraries/QRCode/cmake_install.cmake#L48-L49(this comment)buildsim-posix/Libraries/SDL/cmake_install.cmake#L48-L49buildsim-posix/Tests/cmake_install.cmake (1)
47-74: 🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Remove machine-specific paths from committed POSIX build output.
The generated files embed
/home/ken/Projects/Tactility/...; fresh checkouts therefore cannot reliably run CTest orcmake --install. Stop tracking these generated build files and regenerate them in the active build environment.
buildsim-posix/Tests/cmake_install.cmake#L47-L74: regenerate subdirectory includes and manifest paths relative to the current build.buildsim-posix/Libraries/lvgl/cmake_install.cmake#L46-L89: regenerate install sources, libraries, and manifest paths.buildsim-posix/Libraries/cJSON/cmake_install.cmake#L48-L49: regenerate the local manifest path.buildsim-posix/Libraries/lv_screenshot/cmake_install.cmake#L48-L49: regenerate the local manifest path.buildsim-posix/Tests/TactilityFreeRtos/cmake_install.cmake#L48-L49: regenerate the local manifest path.buildsim-posix/Tests/TactilityKernel/CTestTestfile.cmake#L7-L8: regenerate the test executable and backtrace paths.buildsim-posix/Tests/TactilityKernel/cmake_install.cmake#L48-L49: regenerate the local manifest path.📍 Affects 7 files
buildsim-posix/Tests/cmake_install.cmake#L47-L74(this comment)buildsim-posix/Libraries/lvgl/cmake_install.cmake#L46-L89buildsim-posix/Libraries/cJSON/cmake_install.cmake#L48-L49buildsim-posix/Libraries/lv_screenshot/cmake_install.cmake#L48-L49buildsim-posix/Tests/TactilityFreeRtos/cmake_install.cmake#L48-L49buildsim-posix/Tests/TactilityKernel/CTestTestfile.cmake#L7-L8buildsim-posix/Tests/TactilityKernel/cmake_install.cmake#L48-L49buildsim-posix/Tests/service-module/ServiceModuleTests (1)
1-772: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Compiled binary checked into version control.
This file is a compiled ELF executable (test binary), not source. Binary artifacts should never be committed to a repository — they bloat history irreversibly, cannot be meaningfully reviewed/diffed, and this one embeds local absolute build paths (e.g.
/home/ken/Projects/Tactility/...) which leaks developer-machine details into the repo. This applies to the entirebuildsim-posix/build output directory being added in this PR (including.ninja_deps,.ninja_log,.aarchives,cmake_install.cmakefiles, etc.), not just this binary.Recommend removing
buildsim-posix/from version control entirely and adding it to.gitignore.
1 participant
Extracted the service API from TactilityKernel and put it in a new module at
Modules/service-moduleSummary by CodeRabbit