Validate pipeline specs during submit#29
Merged
Volv-G merged 2 commits intoJul 15, 2026
Merged
Conversation
Run the full pipelines validate authoring validator during pipeline-runs submit and --dry-run after hydration, and route PipelineRunner through the same base hook. Root graph requirements are enforced by the authoring validator, with README and tests updated. Bump tangle-cli patch version to 0.1.3. This is based on master and intentionally excludes PR TangleML#27 skip-validation CLI flag and separate submit-root check. Assisted-By: devx/5490f7cb-c7e4-4cf5-b525-a8c4e2af55b1
Assisted-By: devx/5490f7cb-c7e4-4cf5-b525-a8c4e2af55b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the full local pipeline authoring validator during
tangle sdk pipeline-runs submitand--dry-run, and route the high-level runner path through the same default validation hook. This catches authoring-shape errors locally withPipeline validation failedbefore a pipeline run is created.Also bumps
tangle-clifrom0.1.2to0.1.3.What changed
collect_pipeline_spec_errors(...)alongsidevalidate_pipeline_spec(...)so submit/run flows can compose with the existinglist[str]validation hook contract.validate_pipeline_for_run(...)implementation to the basePipelineRunHooks, so the realPipelineRunManagersubmit path andPipelineRunnerinheritance path share the same behavior.PipelineRunManager.prepare_submit_payload_from_spec(...)choke point, which backs both:tangle sdk pipeline-runs submittangle sdk pipeline-runs submit --dry-run--no-hydrate, the as-is local spec is validated.implementation.graph; a bareimplementation.containerroot fails withimplementation.graph must be an object.Relationship to PR #27
This is independent of PR #27 and is based on
master, not on PR #27. It intentionally does not include PR #27’s proposed--skip-validationCLI flag or separate narrow submit-root check. Instead, submit uses the existing fullpipelines validateauthoring validator at the manager choke point.Test plan
uv run --frozen tangle version→0.1.3uv run --frozen pytest -q→692 passed, 4 warningsuv run --frozen ruff check packages/tangle-cli/src/tangle_cli/__init__.py packages/tangle-cli/src/tangle_cli/pipeline_run_manager.py packages/tangle-cli/src/tangle_cli/pipeline_runner.py packages/tangle-cli/src/tangle_cli/pipelines.py tests/test_pipeline_runs_cli.py tests/test_pipelines_cli.py tests/test_packaging.py→ passedgit diff --check→ passed