scryptenc: check for NULL after humansize() use - #412
Merged
Conversation
cperciva
reviewed
Jul 10, 2026
| free(human_mem_minimum); | ||
|
|
||
| /* Success! */ | ||
| return (0); |
cperciva
reviewed
Jul 10, 2026
| free(human_mem_minimum); | ||
|
|
||
| /* Failure! */ | ||
| return (-1); |
Member
Author
There was a problem hiding this comment.
Whoops, I had that in, then took it out, then mis-added it back.
Member
|
If we're going to pass the return code from And I'm thinking $10 for this one; "crash instead of exiting with an error" is arguably cosmetic, and in this particular case I can't imagine how it could be triggered by accident... in fact I'm not even sure how it could be triggered deliberately without a nerfed malloc. |
Member
Author
|
Added REBASE commit |
Member
|
Fix looks good. Please tidy up the history and set the bounty to $10. |
This should have been part of:
2015-12-27 Use humansize in scryptenc
e446f80
Reported by: ChronoNova
Bug bounty: $10 ("harmless")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.