Add check_params tests - #419
Conversation
|
This uses the same source file, but links it to either the normal scrypt stuff, or a reference-files-only library (with no intrinsics). |
87f896a to
b5dde60
Compare
|
Can you split adding the C file off into a separate commit, and/or add text to the commit messages to clarify the "same source file is used by both tests" situation? I think I understand it now but it took me long enough that I feel it should be clearer. |
This uses the same source file as check-params-normal [*], but
links it only to "reference" algorithm implementations, not the
cpu-intrinsics-aware implementations.
[*] tests/check-params/check-params.c, which was added in the
previous commit.
|
I've updated the commit message of the second commit. I'd rather not add the As it stands now, in theory the first commit could be merged on its own without leaving the tree in an un-sensible state. |
|
Thanks! BTW, when a PR has multiple commits, you normally merge with a merge commit, rather than a linear-history rebase. I'm not fussed either way, but I figured I'd mention it in case it wasn't an intentional change. |
|
Yeah, I could have gone either way on this one. FreeBSD uses a rebase-only model which has made me lean more towards using rebase for this sort of "two commits of which the first can stand entirely independently". If you had turned it into three commits with the first one being "add a C file which will be used later" then I would definitely have merged in order to avoid having a commit which didn't stand by itself. |
2 participants
No description provided.