Libcperciva import - #421
Open
gperciva wants to merge 12 commits into
Open
Conversation
- crypto_aesctr_shared.c: add <stdint.h> for uint64_t & uint8_t. We never compile this file by itself so arguably this isn't necessary, but it's useful to allow static analyzers to parse the file. - humansize.c: add <stdlib.h> for abort()
Reported by: ChronoNova
Bug bounty: $10 ("harmless")
Reported by: Claude Sonnet 4.6
Normally we wouldn't do this in a separate commit, but we want to keep the following commit as adding-parentheses-only.
Reported by: Claude Sonnet 4.6; also used a python script it wrote to find potential missing parentheses
I missed these earlier because they're in ARM test code that isn't compiled on x86. Reported by: clang 19 scan-build (on a raspberry pi)
- for cpusupport/Build/cpusupport-ARM-*.c: we deliberately want
these files to fail to compile if the compiler doesn't support
ARM.
- for everything else: these #includes are already inside #ifdef
CPUSUPPORT_ARM_AES, so we gain nothing from having another
#ifdef.
This now matches the way we handle #includes for x86 intrinsics.
Suggested by: Claude Sonnet 5
Bug bounty: $10 ("harmless")
This problem could not have caused an incomplete password to be read; it
would only have failed to report a rare read error occurring after
fgets() had already succeeded.
Reported by: ChronoNova
Bug bounty: $10 ("harmless")
Note that warnp (and warn/warnx) do not call into warnp_setprogname so
no problem arises from using warnp within warnp.c.
Reported by: Claude Opus 4.6
Bug Bounty value: $10 ("harmless bug")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.