fix: bump the reusable workflow's elp-version default to the OTP 29 release - #73
Merged
Merged
Conversation
…elease #71 moved the default in elp/action.yml but not the one in the reusable workflow, and the workflow's is the one that counts: every ELP job passes `version: ${{ inputs.elp-version }}` unconditionally, so the action's default is unreachable from there. Consumers therefore still resolved 2026-02-27 and still failed with "ships no linux x86_64 binary for OTP 29" - the error was now accurate and actionable, but the release it named was one #71 meant to stop using. Comment says the two must track each other, since nothing enforces it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third and final piece of the OTP 29 ELP fix.
#71 bumped the
versiondefault inelp/action.yml, but the reusable workflow carries its ownelp-versioninput with its own default, and that one wins - every ELP job passesversion: ${{ inputs.elp-version }}unconditionally, so the action's default is unreachable when called through the workflow.Net effect on widgrensit/asobi#436, with the pin already at v2.1.5:
The error is accurate and actionable now (an improvement on the old generic one), but it names the release #71 meant to stop using.
This bumps the workflow default to
2026-08-10to match, with a comment noting the two must track each other since nothing enforces it. Same caveat as #71: that release ships no OTP 26 binary, so a consumer still on 26 must passelp-version: '2026-02-27'.