Split the remaining large files by what they hold - #39
Merged
Merged
Conversation
…lk frame and its tests
… the settle catalog
…m Choices and the Django checks
… exposure, settings, templates and confirms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37: the other large files a blind labeler judged worth splitting, plus the 1,811-line security test file, split by what each part holds.
analysis/clones.rs(1,909)clones/mod.rs838: the matching coreapart.rs170: copies never compared (example, benchmark and retired directories, deprecated code, Bend 2 tests pinned to their output)frame.rs261: the frame of a tree walktests.rs650units/security.rs(1,189)security/mod.rs675: planning, traces, rechecks, confirmssubject.rs242: what a unit is judged onsettle.rs287: the settle catalogunits/questions/security.rs(857)questions/security/mod.rs546: first-pass questions and checksconfirm.rs176: the Choices asked after a findingdjango.rs149: Django's own checksunits/test_units.rs(818)test_units/mod.rs375: value testssetup.rs282: the setup a test runs, read from its filepairs.rs178: redundant pairsunits/tests/security.rs(1,811)tests/security/mod.rs539: traces, callers, settlesplus
php.rs271,kinds.rs216,exposure.rs266,settings.rs256,templates.rs113,confirms.rs181These are pure moves, one commit per file.
pub(super).pub(super)keep their reach aspub(in crate::units).clones::example_code,security::SETTLES,questions::injection_valuesand so on.Subjectand the two fields of the test harness'sRecordingare opened to their module.Checked:
main's once visibility,crate::paths and formatting are normalized (compared mechanically).clones.rs's test module moved unchanged.cargo +1.90.0 check --lockedpass.Not split:
file_kind.rs,test_map.rs,transport.rs,docs/load.rsandanalysis/comments.rs, which the labeler found fine as they are.analysis/units/mod.rsandanalysis/sites.rsare left too; the labeler called them debatable.