Conversation
CjhHa1
requested review from
celve,
haonan3,
leviking98z-rgb and
zzhuoxin1508
as code owners
September 20, 2026 03:45
Collaborator
Author
|
Superseded by the rebased #471: the helper inlining and documentation cleanup are now included there, while the 0.5.12-specific gRPC port correction is obsolete under the 0.5.19 migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grpc_port = port + 10000derivationRelated Issue
N/A — follow-up to #392.
Test Plan
SKIP=no-commit-to-branch uvx pre-commit run --all-files --show-diff-on-failure— passedThe focused assertions remain one-off because the repository intentionally keeps no committed top-level test tree.
Compatibility / Risk
Default warn/strict behavior and filtered output are unchanged. The server-port candidate range expands from 1024–35535 to 1024–55535; under pinned SGLang 0.5.12.post1, an automatically derived gRPC port therefore remains within 65535. No checkpoint, data-format, recipe-value, GPU-count, or memory-requirement changes.
Reviewer Notes
PR #471 migrates SGLang to 0.5.19 and removes the derived-port cap while renaming CUDA-graph fields. If it merges first, this branch should be rebased: the 0.5.12-specific config hunk and wording become obsolete, while the helper inlining and baseline/exception documentation still apply.
AI-assisted implementation; the submitter reviewed the full diff. Duplicate-work review found #471's version-migration overlap described above, but no open PR covering the #392 helper/documentation follow-up.
Checklist