Conversation
CjhHa1
requested review from
Jayce-Ping,
Zcchill,
celve,
haonan3 and
leviking98z-rgb
as code owners
September 20, 2026 04:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the native vLLM packed-IPC path added in #480 against rank-local failures and memory spikes.
Related Issue
N/A
Test Plan
python3 -m pytest -q tests/test_vllm_native_engine.py tests/test_ipc_weight_sync.py(8 passed)SKIP=no-commit-to-branch pre-commit run --all-files --show-diff-on-failureCompatibility / Risk
control_timeout_s <= weight_update_timeout_snow fail during construction instead of timing out asymmetrically during publication.Reviewer Notes
Follow-up to #480. Please focus on
VLLMNativeIPCTrainerEngine._send_planned_packed: source boundaries guard the next FSDP collective, while chunk boundaries guard the default-group IPC-handle gather. The two gates are intentionally distinct.Checklist