fix(ci): migrate github-script to v8 — repair the broken gate check#260
Merged
Conversation
…te check
GitHub's runner infra force-upgrades actions/github-script@v7 to Node 24,
where the script-side require('@actions/github') can no longer resolve.
Every recent PR shows a red 'gate' check with 'Cannot find module
@actions/github' regardless of whether it links an issue.
- Pin actions/github-script to ed597411 (v8.0.0) in pr-triage, ci-nudge,
issue-triage.
- Replace require('@actions/github').getOctokit(APP_TOKEN) with
new (github.constructor)({ auth: APP_TOKEN }) — v8.0.0 injects no
getOctokit helper (verified against src/async-function.ts at the pinned
SHA), and the wrapped require cannot resolve modules without a checkout.
- Bump actions/stale to 1e223db (v10.4.0).
Diagnosis first surfaced by @sandman-sh in #257 — thank you! This lands
separately with a SHA pin and a require-free client construction.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughChangesWorkflow maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
gatecheck (and the ci-nudge/issue-triage bots) is mechanically red on every recent PR: GitHub's runner infra now force-runsactions/github-script@v7on Node 24, where the script-siderequire('@actions/github')can't resolve — the failure has nothing to do with whether a PR links an issue. Sorry for the confusing red ✗ everyone has been seeing.What
actions/github-scripttoed597411… # v8.0.0in pr-triage / ci-nudge / issue-triage.require('@actions/github').getOctokit(APP_TOKEN)withnew (github.constructor)({ auth: APP_TOKEN }). v8.0.0 injects nogetOctokitscript parameter (verified againstsrc/async-function.tsat the pinned SHA), so a require-free construction from the injected client's own class is the safe route.actions/staleto1e223db… # v10.4.0.Diagnosis credit: @sandman-sh first surfaced the Node-24/v8 root cause in #257. 🙏
Note for contributors: existing PRs will show a green
gateafter their next push or re-run.🤖 Generated with Claude Code
Summary by CodeRabbit