tight designs asap7_cva6 ihp_i2c - #4471
Open
LucasYuki wants to merge 1 commit into
Open
Conversation
Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reduces the clock period for the CVA6 design on ASAP7 and the I2C GPIO expander design on IHP SG13G2, updating the corresponding baseline rules and metadata. The review feedback correctly identifies that reducing the clock period to 10.0 while keeping the clock waveform hardcoded to {0 10.0} results in an incorrect 100% duty cycle. It is recommended to dynamically scale the clock waveform based on the clock period variable to maintain a 50% duty cycle.
|
|
||
| create_clock [get_ports clock] -name clock -period 20.0 -waveform {0 10.0} | ||
| create_clock -name vclk -period 20.0 | ||
| create_clock [get_ports clock] -name clock -period $clk_period -waveform {0 10.0} |
Contributor
There was a problem hiding this comment.
The clock waveform is hardcoded to {0 10.0}. Since the clock period $clk_period has been reduced to 10.0, this results in a 100% duty cycle (the clock is high for the entire period). To maintain a 50% duty cycle, the waveform should scale dynamically with the period.
create_clock [get_ports clock] -name clock -period $clk_period -waveform [list 0 [expr {$clk_period / 2.0}]]
|
|
||
| set_ideal_network [get_pins sg13g2_IOPad_io_clock/p2c] | ||
| create_clock [get_pins sg13g2_IOPad_io_clock/p2c] -name clk_core -period 20.0 -waveform {0 10.0} | ||
| create_clock [get_pins sg13g2_IOPad_io_clock/p2c] -name clk_core -period $clk_period -waveform {0 10.0} |
Contributor
There was a problem hiding this comment.
The clock waveform is hardcoded to {0 10.0}. Since the clock period $clk_period has been reduced to 10.0, this results in a 100% duty cycle (the clock is high for the entire period). To maintain a 50% duty cycle, the waveform should scale dynamically with the period.
create_clock [get_pins sg13g2_IOPad_io_clock/p2c] -name clk_core -period $clk_period -waveform [list 0 [expr {$clk_period / 2.0}]]
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 2 with regression(s), 0 without a comparable baseline.
❌ asap7/cva6 base — 3 failing metric(s)
❌ ihp-sg13g2/i2c-gpio-expander base — 6 failing metric(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tight designs: