Export scripts/variables.yaml as a source label - #4473
Open
oharboe wants to merge 1 commit into
Open
Conversation
flow/BUILD's exports_files already publishes scripts/synth.tcl so bazel-orfs can point a rule attribute at @orfs//flow:scripts/synth.tcl rather than vendor a drifting copy. scripts/variables.yaml -- the variable catalogue with each variable's description and stage scoping -- has the same need but no label: it is reachable only inside the private makefile filegroups' data, so a downstream target cannot data-dep the catalogue at a given commit. Add it to the same exports_files. Source-only change, no flow behaviour. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the flow/BUILD file to expose scripts/variables.yaml in the exports_files list, allowing downstream targets to reference the variable catalogue directly. There are no review comments, and I have no feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flow/BUILD'sexports_filesalready publishesscripts/synth.tclso bazel-orfs can point a rule attribute at@orfs//flow:scripts/synth.tclrather than vendor a drifting copy.scripts/variables.yaml— the variable catalogue carrying each variable's description and stage scoping — has the same need but no label: it is reachable only inside the private makefile filegroups'data, so a downstream Bazel target cannotdata-dep the catalogue at a given commit.This adds it to the same
exports_files. Source-visibility only; no flow behaviour changes.