dcalc: Restore TwoPole parasitic reduction - #406
Closed
jhkim-pii wants to merge 1 commit into
Closed
Conversation
Override the TwoPole reduction hook so eager parasitic reduction creates PiPoleResidue2 instead of inheriting the PiElmore implementation. This restores calculator-specific dispatch for placement and reduced SPEF paths. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request overrides the reduceParasitic method in DmpCeffTwoPoleDelayCalc to reduce the parasitic network using reduceToPiPoleResidue2. Feedback was provided to add a defensive null check for the parasitics pointer returned by scene->parasitics(min_max) to prevent a potential null pointer dereference crash.
Comment on lines
+274
to
+276
| Parasitics *parasitics = scene->parasitics(min_max); | ||
| return parasitics->reduceToPiPoleResidue2( | ||
| parasitic_network, drvr_pin, rf, scene, min_max); |
There was a problem hiding this comment.
The scene->parasitics(min_max) call can return nullptr if parasitics are not loaded or available. Dereferencing parasitics without a null check will cause a crash. Please add a defensive null check before calling reduceToPiPoleResidue2.
Parasitics *parasitics = scene->parasitics(min_max);
if (parasitics == nullptr)
return nullptr;
return parasitics->reduceToPiPoleResidue2(
parasitic_network, drvr_pin, rf, scene, min_max);
Contributor
Author
|
Opened in the wrong repository; closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Solution
Impact
Testing
Related
dmp_ceff_two_poleanddmp_ceff_lambert_wdelay calculators OpenROAD#11229