Skip to content

Fix toast effect icon #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TonytheMacaroni merged 1 commit into from
Aug 8, 2026
Merged

Fix toast effect icon #1090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nms/latest/src/main/java/com/nisovin/magicspells/volatilecode/latest/VolatileCodeLatest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public void playHurtSound(LivingEntity entity) {

@Override
public void sendToastEffect(Player receiver, ItemStack icon, AdvancementDisplay.Frame frameType, Component text) {
var iconNms = CraftItemStack.asNMSCopy(icon).getItem();
var iconNms = CraftItemStack.asTemplate(icon);
var textNms = PaperAdventure.asVanilla(text);
var description = PaperAdventure.asVanilla(Component.empty());
AdvancementType frame;
Expand Down
2 changes: 1 addition & 1 deletion ..._1_2/src/main/java/com/nisovin/magicspells/volatilecode/v26_1_2/VolatileCode_v26_1_2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ public void playHurtSound(LivingEntity entity) {

@Override
public void sendToastEffect(Player receiver, ItemStack icon, AdvancementDisplay.Frame frameType, Component text) {
var iconNms = CraftItemStack.asNMSCopy(icon).getItem();
var iconNms = CraftItemStack.asTemplate(icon);
var textNms = PaperAdventure.asVanilla(text);
var description = PaperAdventure.asVanilla(Component.empty());
AdvancementType frame;
Expand Down
Loading