tweak(intro): Implement intro skipping with ESC button#2879
Merged
Conversation
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Source/GameClient/Intro.cpp | Adds intro-stage skipping and removes writes to the former movie-exit flag. |
| Core/GameEngine/Source/GameClient/MessageStream/WindowXlat.cpp | Sends released ESC input to intro skipping before the movie-stop fallback. |
| Generals/Code/GameEngine/Source/GameClient/GameClient.cpp | Adds the Generals forwarding API for intro-stage skipping. |
| GeneralsMD/Code/GameEngine/Source/GameClient/GameClient.cpp | Adds the Zero Hour forwarding API for intro-stage skipping. |
Reviews (2): Last reviewed commit: "Replicate in Generals" | Re-trigger Greptile
|
Can we have left mouse click as well, smartphones don't have esc buttons and console ports (or SDL3 with controllers) have this mapped to the start button. |
Author
Outside the scope of this change imo. |
|
Looks good to me, the switch doesn't have a default which might give us another warning, but that's fine. It's a good QOL improvement :) |
xezon
force-pushed
the
xezon/intro-esc-skip
branch
from
July 20, 2026 20:17
5a709ac to
e848d4c
Compare
Author
|
Replicated in Generals with 1 mini conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements intro skipping with ESC button. Press ESC 3 times to skip the whole intro.
TODO