Skip to content

fix(cli): reject non-positive list limits - #1565

Merged
Open-Squilla merged 1 commit into
TokenRhythm:mainfrom
YIKUAIBANZI:fix/positive-list-limits
Sep 17, 2026
Merged

Open-Squilla merged 1 commit into
TokenRhythm:mainfrom
YIKUAIBANZI:fix/positive-list-limits

Conversation

@YIKUAIBANZI

Copy link
Copy Markdown
Contributor

Summary

  • reject non-positive sessions list and cron runs limits before opening a gateway connection
  • emit the standard INVALID_REQUEST JSON envelope and exit code 2 for invalid CLI input
  • reject non-positive operator sessions.list RPC limits while preserving the published guest-limit clamp behavior
  • add regression coverage for both CLI commands and the legacy sessions RPC adapter

Fixes #1558

Verification

  • uv run ruff check src tests
  • 99 focused CLI/gateway tests passed
  • full suite: 25,349 passed, 259 skipped; four host-tooling failures on macOS were re-run successfully with the Linux CI prerequisites (docker command behavior and GNU sed)
  • npm --prefix opensquilla-webui run build
  • uv build --wheel

Third-party origins

none

@YIKUAIBANZI
YIKUAIBANZI force-pushed the fix/positive-list-limits branch from 4c5c947 to 70f7301 Compare September 13, 2026 08:23
@Open-Squilla
Open-Squilla force-pushed the fix/positive-list-limits branch from 70f7301 to c809428 Compare September 17, 2026 20:00
@Open-Squilla
Open-Squilla added this pull request to the merge queue Sep 17, 2026
@github-actions

Copy link
Copy Markdown

Merge queue CI: successrun 35271115045, attempt 1.
Tested queue candidate: ebe091d20abc951b4c9f7398d13add53119a3bd3. This result belongs to that combined tree, not necessarily the PR's current head.

The run summary lists reused suites and executed checks. A green PR check alone does not mean queue validation has passed.

Merged via the queue into TokenRhythm:main with commit ebe091d Sep 17, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sessions and Cron commands accept negative --limit values

2 participants