fix(sqlite): expose change counts on the fallback connection - #1674
Merged
Merged
Conversation
|
Merge queue CI: success — run 35087537585, attempt 1. The run summary lists reused suites and executed checks. A green PR check alone does not mean queue validation has passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
The SQLite fallback connection omitted
total_changes, although the native aiosqlite connection exposes it. When the fallback was selected, execution-workspace safety tests failed with AttributeError before checking that rejected mutations left the database unchanged. This blocked the merge queue for #1532.Scope boundary: expose the underlying SQLite read-only counter through the compatibility protocol and fallback wrapper, and test the same counter semantics on both backends. There are no initialization changes, new dependencies, changed safety assertions, or test skips.
Branch
Base branch: main.
Target exception: none.
Issue
Linked issue: None.
If None, reason: fixes a merge-queue failure identified while integrating #1532. The exact queue parent and candidate have identical compatibility-layer source and both reproduce the failure when fallback is forced.
Release Note
Release note: Preserve SQLite change-counter compatibility when the asynchronous connection falls back to sqlite3. No standalone changelog entry added.
Tests
git diff --checkpassed.Maintainer Live Check
Maintainer live check: no.
Surface: gateway.
Safety
The existing no-mutation safety assertions remain intact. Tests are offline, deterministic, credential-free, and use synthetic in-memory/temporary databases. No secrets or runtime data are included.
Third-Party Origin
Third-party origin: none.