Add ACF investment report field for pension fund pages

[taavipertman-glitch]

Summary

• Add the investment_report_file ACF field to TUK75, TUK00 and TUV100 fund pages, reusing the exact field name TKF100 already has
• Enable show_in_rest on the field groups that carry it, so the field can be set over the REST API
• Templates use the ACF field when set and fall back to the current hardcoded URL when not

What this enables

• Manual updates from wp-admin: pick the latest report PDF from the media library, as TKF100 does today. No git commit needed.
• Automated updates via REST API: onboarding-service uploads the PDF and sets the field in one step (Add investment report publishing pipeline onboarding-service#1619)

One ACF field name serves all four funds, so #1619 needs no per-fund branching.

Changes

• helpers/acf/fund-pension.php — new field group for page templates page_fund-stocks.php, page_fund-bonds.php, page_fund-third.php
• helpers/acf/init.php — include the new file
• helpers/acf/fund-savings.php — add show_in_rest to group_fund_savings_documents
• fund-stocks-details.php, fund-bonds-details.php, fund-third-details.php — read get_field('investment_report_file'), hardcoded fallback
• helpers/extras.php — generate_report_link() rewrite (see below)
• tests/helpers/ReportLinkTest.php — new coverage for generate_report_link()
• CLAUDE.md — Step 4 no longer claims the ACF REST API is unavailable

show_in_rest is the part that actually makes automation work

onboarding-service posts {"acf": {"investment_report_file": <attachment id>}} to /wp-json/wp/v2/pages/{id}. ACF only honours the acf key when the field group declares 'show_in_rest' => 1; without it the key is dropped and the write silently no-ops. The theme has no acf/rest or register_rest_field filter that would enable this globally.

This gap also existed on group_fund_savings_documents, so TKF100's automated path has never worked either — that group is fixed here too. It is group-level, so all ten savings document fields become REST-readable; every one of them is already rendered publicly on the fund page, so nothing new is exposed. Writes still require edit_post.

Behaviour change in generate_report_link() — affects TKF100 too

This function is shared with fund-savings-details.php. It now derives the report period from a YYYY-MM in the filename, falling back to the old "month before the upload folder" rule only when the filename has no period.

For every URL in the repo today the two rules agree, so no label changes on merge. The rewrite is what makes the ACF path correct: FundReportMapping.buildPdfFilename() always embeds the report period in the filename, while the upload folder is the month the file happened to be uploaded. Those diverge on a media re-upload — see 2bf6f27, where exactly that broke a URL — and the old rule would then mislabel the report.

Also in the rewrite:

• esc_url() / esc_html() on output, replacing an unescaped sprintf
• absolute URLs keep their own host; previously the host was discarded and get_site_url() re-prefixed, which would break media served from another host
• a URL with no date in either the filename or the path no longer produces labels like 12.-1. from intval() on an unmatched preg_match
• guards basename() against parse_url() returning null for a pathless URL

Deploy notes

Safe to deploy. The three pension pages keep rendering their current hardcoded 2026-07 reports until someone sets the ACF field; TKF100 is unaffected until its field changes.

Before treating #1619 as unblocked, confirm in wp-admin that the pages onboarding-service targets by slug are actually on the matching page templates — ACF applies the field group by page_template, while findPageIdBySlug looks up tuleva-maailma-aktsiate-pensionifond, tuleva-maailma-volakirjade-pensionifond, tuleva-iii-samba-pensionifond and taiendav-kogumisfond. If a page is on a different template the write no-ops, which is the same failure mode as the missing show_in_rest.

Follow-up

Once the ACF fields are populated on all four pages, drop the hardcoded fallback URLs. Until then the monthly report update still touches these three templates.

🤖 Generated with Claude Code