Skip to content

Migrate CI to GitHub Actions - #140

Open
stv0g wants to merge 5 commits into
masterfrom
github-ci
Open

Migrate CI to GitHub Actions#140
stv0g wants to merge 5 commits into
masterfrom
github-ci

Conversation

@stv0g

@stv0g stv0g commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Replaces deployment to EONERC Kubernetes with deployment to GitHub pages
  • Removes building of container images
  • Updates references to git.rwth-aachen.de to GitHub
  • Updates VILLASnode submodule
  • Removes documentation for old api node-type (Remove api node type documentation #139)

@stv0g stv0g self-assigned this Jul 30, 2026
@stv0g stv0g added the ci label Jul 30, 2026
@stv0g
stv0g force-pushed the github-ci branch 4 times, most recently from 91802f5 to 581f946 Compare July 30, 2026 21:15
@steffen-vogel-opalrt
fix(ci): Delete obsolete Kuberenetes manifests
9e6092b 
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
@stv0g
stv0g force-pushed the github-ci branch 5 times, most recently from b16807e to 0245dfc Compare July 30, 2026 21:39
pjungkamp and others added 3 commits July 31, 2026 07:29
@pjungkamp @steffen-vogel-opalrt
Remove api node type documentation
8c21233 
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
@steffen-vogel-opalrt
fix(docs): Remove more outdated references to git.rwth-aachen.de
cd23794 
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
@steffen-vogel-opalrt
fix(ci): Remove GitLab CI config
09e412e 
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
@stv0g
stv0g force-pushed the github-ci branch 2 times, most recently from 0d33c96 to 52ed655 Compare July 31, 2026 05:45
@stv0g stv0g mentioned this pull request Jul 31, 2026
Open
@stv0g stv0g linked an issue Jul 31, 2026 that may be closed by this pull request
Remove old docs #141
Open
leonardocarreras
leonardocarreras reviewed Jul 31, 2026
View reviewed changes

@leonardocarreras leonardocarreras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stv0g! Looks nice, I think there are just few comments that you might want to think about.

Comment thread docs/node/installation.md Outdated
- [Pre-compiled standalone binaries](#standalone)
- [Pre-compiled RPM package](#rpm)
- [Docker image](https://git.rwth-aachen.de/acs/public/villas/node/container_registry)
- [Container image](https://github.com/VILLASframework/node/pkgs/container/villas%2Fnode)

@leonardocarreras leonardocarreras Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/VILLASframework/node/pkgs/container/node ? depends on VILLASframework/node#1037

@steffen-vogel-opalrt steffen-vogel-opalrt Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f4877b1

Comment thread docs/node/installation.md Outdated

```shell
docker run --privileged registry.git.rwth-aachen.de/acs/public/villas/node
docker run --privileged rghcr.io/villasframework/villas/node

@leonardocarreras leonardocarreras Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghcr.io/villasframework/node ?

@steffen-vogel-opalrt steffen-vogel-opalrt Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f4877b1

Comment thread docs/node/installation.md Outdated

```shell
docker run --volume /path/to/my/local.conf:/config.conf --privileged registry.git.rwth-aachen.de/acs/public/villas/node node /config.conf
docker run --volume /path/to/my/local.conf:/config.conf --privileged ghcr.io/villasframework/villas/node node /config.conf

@leonardocarreras leonardocarreras Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghcr.io/villasframework/node ?

@steffen-vogel-opalrt steffen-vogel-opalrt Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f4877b1

Comment thread Makefile
--workdir /documentation \
$(DOCKER_IMAGE):$(DOCKER_TAG)-dev

deploy:

@leonardocarreras leonardocarreras Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are we going to deploy it now to fein?

@steffen-vogel-opalrt steffen-vogel-opalrt Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its only going to be deployed to GitHub pages. We then update the DNS-CNAME record of villas.fein-aachen.org to point to the GitHub servers.

@leonardocarreras @al3xa23 Could you take care of this? I believe Stefan Lankes has the credentials to the Hosteurope customer interface where those settings can be changed.

Comment thread .github/workflows/build.yaml
pages: write
id-token: write

steps:

@leonardocarreras leonardocarreras Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make the fein website to take it automatically? an example from DPsim

https://github.com/sogno-platform/dpsim/blob/9e864daa8458a08bb7d59bfe818faa51f41c88f7/.github/workflows/documentation-fein.yaml#L36

@steffen-vogel-opalrt steffen-vogel-opalrt Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. We only would deploy to GitHub pages.

@steffen-vogel-opalrt
feat(ci): Add GitHub Actions config
36097ab 
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardocarreras leonardocarreras leonardocarreras left review comments
@al3xa23 al3xa23 Awaiting requested review from al3xa23
+1 more reviewer
@steffen-vogel-opalrt steffen-vogel-opalrt steffen-vogel-opalrt left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@stv0g stv0g

Labels

ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove old docs

4 participants

@stv0g @leonardocarreras @steffen-vogel-opalrt @pjungkamp