Explicitly specify all default symmetries for deserialization - #598
Merged
Conversation
This changes the default from the implicit BraKetSymmetry::Conjugate to BraKetSymmetry::Nonsymm. Since this is gets included in a tensor's hash and we order products and sums based on term hashes, this also changes the order of certain terms and hence the generated ITF code. The changed codes have been numerically verified to still produce the correct results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the default from the implicit BraKetSymmetry::Conjugate to BraKetSymmetry::Nonsymm. Since this is gets included in a tensor's hash and we order products and sums based on term hashes, this also changes the order of certain terms and hence the generated ITF code. The changed codes have been numerically verified to still produce the correct results.