fix(backup): paginate cloud backup listings - #415
Open
zjubiology wants to merge 1 commit into
Open
zjubiology wants to merge 1 commit into
zjubiology wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cloud storage listings are paginated, but the backup commands only fetched the first page.
This caused three incomplete behaviors when an account had more backups than a single page could contain:
slv backup listonly displayed the first pageStorageListResalready exposescursorandtruncated, and the storage list and prefix-delete commands already follow the cursor until all pages have been retrieved.Fix
listAllBackupshelper that followscursorwhile the response is truncatedslv backup listTesting
cursor: "next"