Conversation
Generalize the portal switch so the leaving game can ask for a specific arrival entrance in the other game. The leaving DLL stages the target (Combo_RequestCrossSwitch) and raises the existing portal flag; the launcher drains it (SOH_/MM_GetPendingCrossTarget) and pushes it as a one-shot arrival override (SOH_/MM_SetTargetEntrance) before the other game's boot/resume, where TitleSetup_InitImpl / Setup_InitImpl honour it instead of the hardcoded Mask Shop / South Clock Town arrivals. OOT routes the target through Entrance_OverrideNextIndex like its own warp songs. Groundwork for cross-game teleport songs (Song of Soaring in OOT, OOT warp songs in MM). Export shape mirrors feat/cross-entrances.
fix(soh): owl frame - MAP title band on top, name plate below the map fix: make owl map more pause menu like
# Conflicts: # docs/deviations/rando.md # mm/2s2h/BenPort.h # soh/soh/OTRGlobals.cpp
…eature/cross-teleport-songs
…eature/cross-teleport-songs
- fix comments back to human understanding, not for an agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds game specific teleportation songs (like the newer split that OOTMM does) to each game.
Song of Soaringwhich can fly to any active owl statues in MM.MinuettoPreludeLimitations:
Song of Soaring (OOT)isn't the logicalSong of Soaring (MM)Song of Soaringinstead of the song itself.Build Artifacts