ci: fix GitHub Actions (clang build break + test gating) - #6
Merged
Conversation
…gating with GitLab Two failures broke the GitHub workflow on master while GitLab stayed green: 1. clang (macOS + ubuntu) rejected AST.hpp: Declarator::FunctionInfo holds std::vector<Parameter> by value, and Declarator's implicitly-defined virtual destructor (via Node) is required at the end of the class definition — where Parameter was still only forward-declared. GitLab never saw this because it builds with gcc only. Move the Parameter definition above Declarator. 2. The workflow ran the full ctest suite, so the two status-deferred conformance rows (std-lang-6.7.1-03, 6.7.6.2-04 — known master regressions of intentionally-deferred features) gated the pipeline. GitLab's policy gates on host/unit tests (--label-exclude standard) only, with the scaffold informational. Split the test step to mirror that policy, plus a gating status-supported run (100% green). Also modernize the workflow after WasmVM's main.yml: top-level concurrency, timeout-minutes, include-form matrix, macos-latest, actually use the Ninja generator that was installed but unused, and drop the ccache/build-dir caches and full-build-dir failure artifact (now Testing/ + logs only). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation PR to run the fixed workflow on real CI — the canonical review happens on GitLab (self-hosted); this will be closed once the change lands on master via the GitLab MR.
Fixes the two failures from the master run 29809260884:
clang build break:
Declarator::FunctionInfoholdsstd::vector<Parameter>by value whileParameterwas only forward-declared; clang requires the complete type when definingDeclarator's implicit virtual destructor at the end of the class.Parameteris now defined beforeDeclarator. (GitLab builds gcc-only, so this never surfaced there.)Test gating: the workflow ran the full ctest suite, so two
status-deferredconformance rows (known regressions of intentionally-deferred features) gated the run. The test step now mirrors GitLab's gating policy: host/unit tests (--label-exclude standard) + thestatus-supportedconformance rows.Also modernizes the workflow after WasmVM's
main.yml(concurrency, timeouts, Ninja generator, no stale caches).🤖 Generated with Claude Code