Skip to content

Improve WeBaseTag contrast #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuewill merged 1 commit into from
Aug 5, 2026
Merged

Improve WeBaseTag contrast #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @webaseui/docs

## 0.0.3

### Patch Changes

- Updated dependencies
- @webaseui/svelte@0.3.2

## 0.0.2

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions apps/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@webaseui/docs",
"version": "0.0.2",
"version": "0.0.3",
"private": true,
"type": "module",
"scripts": {
Expand All @@ -9,7 +9,7 @@
},
"dependencies": {
"@webaseui/core": "0.1.0",
"@webaseui/svelte": "0.3.1",
"@webaseui/svelte": "0.3.2",
"svelte": "^5.56.8"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion apps/docs/src/App.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,5 +180,5 @@ import { WeBaseButton } from '@webaseui/svelte';`}</code></pre>

<footer>
<span>WeOpen / WeBaseUI</span>
<span>Core 0.1.0 · Svelte 0.3.0</span>
<span>Core 0.1.0 · Svelte 0.3.2</span>
</footer>
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions packages/webaseui-svelte/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 0.3.2

### Patch Changes

- Improve WeBaseTag small-text contrast in light and dark themes.

## 0.3.1

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/webaseui-svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@webaseui/svelte",
"version": "0.3.1",
"version": "0.3.2",
"description": "Svelte 5 components for WeBaseUI.",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions packages/webaseui-svelte/src/lib/components/WeBaseTag.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@
text-transform: uppercase;
transition: color var(--duration-ui) var(--ease-out), border-color var(--duration-ui) var(--ease-out), background-color var(--duration-ui) var(--ease-out);
}
.ds-tag-neutral { color: var(--ink-muted); background: var(--surface-muted); }
.ds-tag-neutral { color: var(--ink-soft); background: var(--surface-muted); }
.ds-tag-brand { color: var(--brand); background: var(--brand-tint); }
.ds-tag-outline { border-color: var(--hairline-strong); color: var(--ink-soft); background: transparent; }
a.ds-tag:hover, .ds-tag.selected { border-color: var(--brand); color: var(--brand); background: var(--brand-tint); }
a.ds-tag:focus-visible { outline: var(--focus-ring); outline-offset: var(--focus-ring-offset); }
small { color: currentColor; font-family: var(--mono); font-size: 9px; opacity: .75; }
small { color: currentColor; font-family: var(--mono); font-size: 9px; opacity: 1; }
@media (prefers-reduced-motion: reduce) { .ds-tag { transition: none; } }
</style>
12 changes: 12 additions & 0 deletions scripts/check-webaseui-packages.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ const tokenSource = readFileSync(
path.join(root, 'packages/webaseui-core/src/tokens.css'),
'utf8'
);
const tagSource = readFileSync(
path.join(root, 'packages/webaseui-svelte/src/lib/components/WeBaseTag.svelte'),
'utf8'
);
const publicComponents = [
...publicIndex.matchAll(/export \{ default as (WeBase[A-Za-z]+) \}/g)
].map((match) => match[1]);
Expand Down Expand Up @@ -105,6 +109,14 @@ invariant(publicComponents.length === 28, `expected 28 public components, found
for (const component of navigationPrimitives) {
invariant(publicComponents.includes(component), `${component} must be exported from the package root`);
}
invariant(
tagSource.includes('.ds-tag-neutral { color: var(--ink-soft);'),
'WeBaseTag neutral text must use the accessible ink-soft token'
);
invariant(
/small \{[^}]*opacity:\s*1;/.test(tagSource),
'WeBaseTag counts must remain fully opaque for small-text contrast'
);
invariant(
legacyBrandReferences.length === 0,
`legacy brand naming remains in: ${legacyBrandReferences.join(', ')}`
Expand Down