Skip to content

Update to SQLite 3.53.2 and MC 2.3.5 - #173

Closed
Chris-SP365 wants to merge 1 commit into
Willena:masterfrom
Chris-SP365:master
Closed

Chris-SP365 wants to merge 1 commit into
Willena:masterfrom
Chris-SP365:master

Conversation

@Chris-SP365

Copy link
Copy Markdown

No description provided.

Comment thread Makefile.common
MAC_SDK := /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk
endif
Mac-x86_64_CCFLAGS := -I$(MAC_SDK)/System/Library/Frameworks/JavaVM.framework/Headers -Ilib/inc_mac -Os -fPIC -mmacosx-version-min=10.6 -fvisibility=hidden -msse4.2 -maes -Wno-implicit-function-declaration
Mac-x86_64_CCFLAGS := -I$(MAC_SDK)/System/Library/Frameworks/JavaVM.framework/Headers -Ilib/inc_mac -Os -fPIC -mmacosx-version-min=10.6 -fvisibility=hidden -msse4.2 -maes -Wno-implicit-function-declaration -include CommonCrypto/CommonCryptor.h

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issue building the native library without this additional include. Any reason I should add it ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have left a comment on this. I revived my 3 years old VM with everything preconfigured. I assumed since it's docker it should build everything the same. But maybe there was some kind of misconfiugration on my side, because I built it with VERSION and pom.xml updates and maybe without project update first. So yes, feel free to adapt it.

@Willena

Willena commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Thanks for your contribution, you made me realize the project was not up to date.

It is now up to date with the latest MC version & synced with the upstream repository.
Note: The additional include` is not required.

@Willena Willena closed this Jul 5, 2026
@Chris-SP365

Copy link
Copy Markdown
Author

We were hit once by utelle/SQLite3MultipleCiphers#228
so we needed the update. Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants