Enhancement: Use distinct visual styles for different issue types #1384#1388
Open
kmfoysal06 wants to merge 1 commit into
Open
Enhancement: Use distinct visual styles for different issue types #1384#1388kmfoysal06 wants to merge 1 commit into
kmfoysal06 wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
davidperezgar
approved these changes
Jul 10, 2026
Member
davidperezgar
left a comment
Member
There was a problem hiding this comment.
Change colors less aggresive.
Author
|
Hello @davidperezgar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What?
Closes #1384
Using badges instead of raw ERROR/WARNING text to improve the user experience.
Why?
As a Plugin Check user, I always use it before pushing any version of my plugin. I noticed that it's hard to visually distinguish errors and warnings. Even though I can turn warnings/errors off, using badges makes it easier for our brains to quickly identify whether something is an error or a warning, making it slightly more effective. I noticed someone had already created an issue, and I thought I would try to implement it myself since it's not a huge change.
How?
As a fix, I added custom classes
plugin-check__results-row-typeandplugin-check__results-row-type--{{error_type}}, and wrapped the ERROR/WARNING text inside a<span>. I also added custom CSS to theassets/css/plugin-check-admin.cssfile with a proper comment. I used#dc3545as the ERROR badge background color and#ffc107as the WARNING badge background color.Testing Instructions
AI Usage Disclosure
It's a tiny change. I did it myself, but I used AI to fix typos and grammatical mistakes in the PR message.
Screenshots
Co-authored-by: kmfoysal06 kmfoysal06@git.wordpress.org
Co-authored-by: tushar-addweb tusharaddweb@git.wordpress.org