Skip to content

Trac: Restore WP.org color scheme for tickets - #762

Closed
obenland wants to merge 1 commit into
WordPress:trunkfrom
obenland:fix/trac-ticket-color-scheme
Closed

Trac: Restore WP.org color scheme for tickets#762
obenland wants to merge 1 commit into
WordPress:trunkfrom
obenland:fix/trac-ticket-color-scheme

Conversation

@obenland

@obenland obenland commented Aug 4, 2026

Copy link
Copy Markdown
Member

Fixes #8391

Summary

Trac 1.6 changed the ticket page markup: content is now wrapped in a new #ticketbox div nested inside #ticket, and the description heading was renamed from h3 to h2. wp-trac.css's overrides were still written against the pre-1.6 structure, so several selectors silently stopped matching:

  • #ticket > h2 no longer matched the id/status/type badge line (it's now a grandchild of #ticket, not a direct child), losing its font-size override.
  • #ticket's background/border no longer reached the actual box — Trac's own ticket.css now colors the nested #ticketbox (yellow background, double border).
  • Trac's ticket.css now also colors the ticket title (#trac-ticket-title, an h1 wrapping the summary) via a grouped #ticketbox > h1, #ticketbox > h2 { color: #844 } rule. That h1 target didn't exist pre-1.6, so the summary text picked up Trac's maroon color with no WP.org override in place.
  • #ticket div.description h3 stopped matching the description heading, which Trac renamed to h2, losing its color/border-bottom override.

Changes

  • Move the box background/border/radius and badge-line font-size overrides from #ticket to #ticketbox.
  • Add a color reset for #ticketbox > h1 (the ticket title/summary).
  • Update the description heading selector from h3 to h2.
  • Drop the unrelated but noticed-along-the-way dead -webkit-border-radius declarations throughout the file (unprefixed border-radius has been supported everywhere since ~2012).

Test plan

  • Load a ticket page and confirm the ticket box has a single gray border with no yellow background.
  • Confirm the ticket summary/title text is no longer maroon.
  • Confirm the "Description" section heading uses the neutral WP.org gray, not the native Trac color/border.

…up change.

The Trac 1.6 upgrade wraps ticket content in a new #ticketbox div
inside #ticket, and renamed the description heading from h3 to h2.
wp-trac.css's overrides were still targeting the old #ticket
child/descendant structure, so several selectors silently stopped
matching:

* #ticket > h2 never matched the badge line (id/status/type) anymore,
  losing its font-size override.
* #ticket's own background/border no longer visually reached the
  actual box, since ticket.css now colors the nested #ticketbox
  (yellow background, double border).
* Trac's ticket.css now also colors the new #trac-ticket-title h1
  (which wraps the ticket summary) via a grouped
  '#ticketbox > h1, #ticketbox > h2 { color: #844 }' rule, a target
  that never existed pre-1.6, so the summary text picked up Trac's
  maroon color with no WP.org override in place.
* #ticket div.description h3 stopped matching the description
  heading, which Trac renamed to h2.

Move the box background/border/radius and h2 font-size overrides to
#ticketbox, add a color reset for #ticketbox > h1, and rename the
description heading selector to h2.

Fixes https://meta.trac.wordpress.org/ticket/8391

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 4, 2026 13:25
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props obenland.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The selector updates are consistent with the described Trac 1.6 markup changes and do not introduce any apparent regressions within the stylesheet.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Updates the WordPress.org Trac stylesheet to restore the WP.org ticket page appearance after Trac 1.6 markup changes (new #ticketbox wrapper and heading level updates), ensuring the intended WP.org overrides apply again.

Changes:

  • Moves the ticket box visual styling (background/border/radius) and header font-size override to target #ticketbox instead of #ticket.
  • Resets the ticket title color by overriding Trac’s #ticketbox > h1 coloring.
  • Updates the Description section heading selector to match Trac 1.6’s h2, and removes legacy -webkit-border-radius declarations.
File summaries
File Description
wordpress.org/public_html/style/trac/wp-trac.css Adjusts selectors for Trac 1.6 ticket markup so WP.org ticket styling (box chrome, title color, description header) is correctly applied again.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@bazza bazza closed this in e99093e Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants