Trac: Restore WP.org color scheme for tickets - #762
Conversation
…up change.
The Trac 1.6 upgrade wraps ticket content in a new #ticketbox div
inside #ticket, and renamed the description heading from h3 to h2.
wp-trac.css's overrides were still targeting the old #ticket
child/descendant structure, so several selectors silently stopped
matching:
* #ticket > h2 never matched the badge line (id/status/type) anymore,
losing its font-size override.
* #ticket's own background/border no longer visually reached the
actual box, since ticket.css now colors the nested #ticketbox
(yellow background, double border).
* Trac's ticket.css now also colors the new #trac-ticket-title h1
(which wraps the ticket summary) via a grouped
'#ticketbox > h1, #ticketbox > h2 { color: #844 }' rule, a target
that never existed pre-1.6, so the summary text picked up Trac's
maroon color with no WP.org override in place.
* #ticket div.description h3 stopped matching the description
heading, which Trac renamed to h2.
Move the box background/border/radius and h2 font-size overrides to
#ticketbox, add a color reset for #ticketbox > h1, and rename the
description heading selector to h2.
Fixes https://meta.trac.wordpress.org/ticket/8391
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
🟢 Ready to approve
The selector updates are consistent with the described Trac 1.6 markup changes and do not introduce any apparent regressions within the stylesheet.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates the WordPress.org Trac stylesheet to restore the WP.org ticket page appearance after Trac 1.6 markup changes (new #ticketbox wrapper and heading level updates), ensuring the intended WP.org overrides apply again.
Changes:
- Moves the ticket box visual styling (background/border/radius) and header font-size override to target
#ticketboxinstead of#ticket. - Resets the ticket title color by overriding Trac’s
#ticketbox > h1coloring. - Updates the Description section heading selector to match Trac 1.6’s
h2, and removes legacy-webkit-border-radiusdeclarations.
File summaries
| File | Description |
|---|---|
| wordpress.org/public_html/style/trac/wp-trac.css | Adjusts selectors for Trac 1.6 ticket markup so WP.org ticket styling (box chrome, title color, description header) is correctly applied again. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Fixes #8391
Summary
Trac 1.6 changed the ticket page markup: content is now wrapped in a new
#ticketboxdiv nested inside#ticket, and the description heading was renamed fromh3toh2.wp-trac.css's overrides were still written against the pre-1.6 structure, so several selectors silently stopped matching:#ticket > h2no longer matched the id/status/type badge line (it's now a grandchild of#ticket, not a direct child), losing itsfont-sizeoverride.#ticket's background/border no longer reached the actual box — Trac's ownticket.cssnow colors the nested#ticketbox(yellow background, double border).ticket.cssnow also colors the ticket title (#trac-ticket-title, anh1wrapping the summary) via a grouped#ticketbox > h1, #ticketbox > h2 { color: #844 }rule. Thath1target didn't exist pre-1.6, so the summary text picked up Trac's maroon color with no WP.org override in place.#ticket div.description h3stopped matching the description heading, which Trac renamed toh2, losing its color/border-bottom override.Changes
font-sizeoverrides from#ticketto#ticketbox.#ticketbox > h1(the ticket title/summary).h3toh2.-webkit-border-radiusdeclarations throughout the file (unprefixedborder-radiushas been supported everywhere since ~2012).Test plan