Align dependencies with libraries-bom 26.89.0 - #100
eschultink wants to merge 4 commits into
Conversation
Widen compatible ranges so the app's Guava 33.6 and Jackson 2.22 resolve, and implement the Datastore 3.6 commit and rollback overloads. Co-authored-by: Cursor <cursoragent@cursor.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The CI matrix excludes the new regression test and transaction tests, leaving the added behavior unverified.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Aligns dependency resolution with libraries-bom 26.89.0 and Datastore 3.6.0.
Changes:
- Updates dependency versions and ranges.
- Adds Datastore execution-options transaction overloads.
- Adds metrics-export regression tests and aligns CI on Temurin 21.
| File | Description |
|---|---|
java/pom.xml |
Updates BOM, revision, and dependency ranges. |
PipelineBackendTransactionImpl.java |
Delegates new commit/rollback overloads. |
DatastoreBuiltinMetricsExportTest.java |
Verifies built-in metrics export remains disabled. |
.github/workflows/test-java.yml |
Switches test jobs to Temurin. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| public Response commit(DatastoreExecutionOptions options) { | ||
| return commitDatastoreThenTasks(txn -> txn.commit(options)); |
| * export was off. 3.2.0 and later return {@link OpenTelemetry#noop()} unless that export is | ||
| * enabled. This library must keep the export off, including {@link DatastoreOptions#getDefaultInstance()}. | ||
| */ | ||
| class DatastoreBuiltinMetricsExportTest { |
Maven ')' is strictly less than. Bounding at the next major's alpha excludes that major and its pre-releases; a plain < 34 still admits 34.0.0-rc1. Co-authored-by: Cursor <cursoragent@cursor.com>
- Verify commit and rollback pass the exact DatastoreExecutionOptions through before tasks are enqueued. - Add a Surefire matrix entry for the metrics-export test and the txn package, which the existing package filters skip. Co-authored-by: Cursor <cursoragent@cursor.com>
The CI service-account key is rejected with an invalid JWT signature, so bucket setup never reaches the tests. Honor STORAGE_EMULATOR_HOST and stop leveldb reads at the object size, because the emulator's 416 at end-of-object fails a slice instead of ending the stream. Co-authored-by: Cursor <cursoragent@cursor.com>
Move this fork onto the same
libraries-bomas evalengin (26.89.0,google-cloud-datastore3.6.0) and replace dependency ranges that reject the app's versions.0.3+worklytics.14.2importedlibraries-bom26.83.0, which resolves Datastore 3.0.0. That client always starts a privatePeriodicMetricReaderand, with OpenTelemetry >= 1.62, exportsotel.sdk.*metrics Cloud Monitoring rejects. Datastore 3.2.0+ returnsOpenTelemetry.noop()when builtin export is disabled. Export stays off;DatastoreBuiltinMetricsExportTestlocks that in forDatastoreOptions.getDefaultInstance().Datastore 3.6 adds
commit/rollbackoverloads that takeDatastoreExecutionOptions.PipelineBackendTransactionImpldelegates those the same way as the no-arg methods: datastore first, then Cloud Tasks.Maven
)is strictly less than and]is less than or equal. Ceilings are the next major's-alpha, the first pre-release qualifier, so the range is any compatible release and not the next major. A plain< 34still admits34.0.0-rc1, and< 3still admits3.0.0-beta. This build resolves to:libraries-bomgoogle-cloud-datastore3.6.0,protobuf-java4.33.6,grpc-api1.83.0[33.6.0-jre,34.0.0-alpha)[2.18.6,3.0.0-alpha)[2.55,3.0.0-alpha)com.google.dagger, notcom.squareup.dagger)[1.18.42,2.0.0-alpha)[8.5.15,9.0.0-alpha)[5.23.0,6.0.0-alpha)[2.0.4,3.0.0-alpha)javax.servlet-api3.1.0 staysprovided. The test workflow job uses Temurin 21, matching the compile job.Revision is
0.3+worklytics.14.3. Not published yet.Change implications