833: fix missing opening square bracket on unicode character set - #864
Open
lindsay-stevens wants to merge 1 commit into
Open
lindsay-stevens wants to merge 1 commit into
lindsay-stevens wants to merge 1 commit into
Conversation
- test case includes characters in the broken range as an example. The intent of the regex is to match XML so it should have allowed them. - not quite a regression since although typo has been present since 2024, the previous regex validation only allowed ascii characters. Also the error message just says "letters" are allowed rather than specifying that a particular type of letter is supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #833
Why is this the best possible solution? Were any other approaches considered?
I think this is the only way to fix it? There is the option to only allow ASCII letters but that seems unnecessarily restrictive.
What are the regression risks?
Fixes a bug.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
N/A
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code