Fix urllib3 getheaders/getheader deprecation in RESTResponse (#195)#232
Open
CedricConday wants to merge 1 commit into
Open
Fix urllib3 getheaders/getheader deprecation in RESTResponse (#195)#232CedricConday wants to merge 1 commit into
CedricConday wants to merge 1 commit into
Conversation
…#195) urllib3 deprecated HTTPResponse.getheaders() and getheader() in favour of accessing HTTPResponse.headers directly. RESTResponse wrapped those deprecated accessors, emitting DeprecationWarnings on every response and risking breakage when urllib3 removes them. Read headers via .headers / .headers.get() instead. The public RESTResponse.getheaders()/getheader() methods are unchanged, so callers in api_client and exceptions keep working. Adds regression tests pinning the wrapper to the non-deprecated accessors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens #225, which was closed in error (an automated cleanup pass on my account closed a batch of valid PRs and deleted their branches — this restores the work).
urllib3 deprecated
HTTPResponse.getheaders()/getheader()in favour of accessingHTTPResponse.headersdirectly.RESTResponsewrapped those deprecated accessors, emittingDeprecationWarnings on every response. This switches to the non-deprecated API. Fixes #195.