feat(glass): tablet dual-pane liquid glass for 1.6.2 - #70
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2149620f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d32f4e9707
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| find("bottom_navigation_root_flat") ?: find("bottom_navigation_root_stacked") | ||
|
|
||
| // The flat holder reserves miniplayer_height only (no navigation_tabs_height). | ||
| override fun nativePeekBaseline(): Int = bottomInset + dimen("miniplayer_height") |
There was a problem hiding this comment.
Use the stacked-holder baseline here rather than omitting navigation_tabs_height. The dual-pane hook explicitly replaces the flat holder with StackedBottomNavigationHolder, and the base session models that holder as bottomInset + navigation_tabs_height + miniplayer_height. Because the glass hooks are commonly installed after the holder's initial native peek write, NativePeekHeight.initialize() retains this fallback and close() writes it back; rotating out of tablet landscape, disabling dual-pane, or fail-closing the session can therefore restore a peek that is one tab-bar height too short, leaving the collapsed player/navigation geometry overlapped until the host resets it.
Useful? React with 👍 / 👎.
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Validation
:glass:testDebugUnitTest :app:testDebugUnitTest :app:assembleRelease --offlinepassed.python scripts/verify-glass-reference.pypassed (33 original upstream files and one declared patch).Supersedes #68, which was closed before the final interaction and performance changes.