feat: 移植强制显示蜂窝数据入口 - #72
Merged
Merged
Conversation
Owner
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a429802b67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在无 SIM 的设备上,Apple Music 会删除原生“数据”分组,并在播放层将蜂窝使用偏好判定为不可用。本 PR 移植 HyperLyrics-Enhanced 的处理方式,新增默认关闭的“强制显示蜂窝数据入口”,保留原生设置与用户自己的蜂窝使用开关。
功能独立于双栏、标题修正和屏幕方向。仅适配 Apple Music 6.5.2/1586、6.5.3/1599;其他版本跳过,方法缺失时降级。设置构建期间的 SIM 判断只放行一次,使用线程栈隔离嵌套调用,并在退出时清理;蜂窝可用性查询读取实时开关。三处 Hook 全部注册成功后才允许覆盖结果,安装或配置读取失败时保持原生行为。配置 schema 升级至 15,并接入现有嵌入式设置与存储。
验证:
:app:testDebugUnitTest共 810 项全部通过。:app:assembleDebug、:app:assembleRelease、release vital lint 通过。git diff --check通过。已上传测试模块 APK:pre-release。该附件是 AM++ 模块包,尚未重新打包 Apple Music 嵌入版。实现细节、二进制证据及设备验收矩阵见
docs/tablet-cellular-entry-port-analysis.md。本次文案调整:移除蜂窝数据入口设置副标题中的版本号,显示为“恢复原生蜂窝数据设置 · 重开应用后显示”。调整后
:app:compileDebugKotlin与git diff --check通过。Review 修复(5a9d012):蜂窝开关基于点击时最新的对话框草稿更新,保留其他设置保存失败后的待保存值;保存按钮可以重试完整草稿。新增三项回归测试,覆盖其他行保存失败后切换蜂窝入口、蜂窝入口也保存失败后重试、同页连续修改。修复后 810 项单元测试、Debug 构建及
git diff --check通过。