Skip to content

[MISC] Withdraw use_file_history from structure_file, sync spec to unstract#2290 - #31

Merged
chandrasekharan-zipstack merged 3 commits into
mainfrom
fix/withdraw-use-file-history
Sep 18, 2026
Merged

chandrasekharan-zipstack merged 3 commits into
mainfrom
fix/withdraw-use-file-history

Conversation

@chandrasekharan-zipstack

Copy link
Copy Markdown
Contributor

Why

use_file_history is an internal-only option on the execute request. Zipstack/unstract#2290 withdraws it from the published spec, so this client stops declaring and forwarding it. The kwarg was undocumented, added 2026-08-12 in c291e36, with no known callers.

What changed

  • specs/docstudio-oss.json synced to Zipstack/unstract 3851a5866 (the head of #2290); SPEC_SOURCE in tools/gen_sdk.sh records that commit and the file's sha256.
  • _sdk_docstudio regenerated: ExecuteRequest loses use_file_history; APIDeploymentSummary gains owner_emails, added upstream in UN-3853 [FIX] Attribute platform-key-created resources to the API key's creator unstract#2274 since the last sync (additive, generated model only -- the facade returns listing rows as dicts).
  • structure_file() drops the use_file_history keyword, its docstring line and its entry in the request dict.
  • Tests: structure_file(use_file_history=...) raises TypeError; no execute part, send-only name or generated request field is use_file_history; the listing fixture carries owner_emails.

tests/baseline/ is untouched: it vendors the released 1.5.3 wheel, which predates the kwarg, so the parity baseline and its hash do not move.

Version

Removing a keyword argument is breaking by semver, which would mean major (2.0.0). The argument was undocumented, five weeks old and unused as far as we know, so minor (1.8.0) is defensible. Proposed: minor. Chandru decides at release dispatch; nothing here records a version.

Before this leaves draft

The SPEC_SOURCE commit line will be updated to the squash-merge sha of Zipstack/unstract#2290 once it merges.

Tests

uv run pytest tests/: 460 passed. ruff check src/: clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_014f9oEEYspPH4fmPULTnLkJ

`ExecuteRequest` loses `use_file_history`, withdrawn from the published
spec as an internal-only option (Zipstack/unstract#2290). The listing's
`APIDeploymentSummary` gains `owner_emails`, added upstream since the last
sync.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014f9oEEYspPH4fmPULTnLkJ
The generated request no longer carries the field, so the facade could
only have raised on it at the call; refusing it at the signature says so
up front. The listing fixture gains the owner_emails the spec now requires.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014f9oEEYspPH4fmPULTnLkJ
@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

via Greptile

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no new actionable defects identified.

Summary

This PR synchronizes the DocStudio specification and generated SDK while removing the withdrawn use_file_history facade parameter.

  • Removes use_file_history from the execute schema, generated request model, and structure_file().
  • Adds generated support for deployment owner_emails.
  • Updates compatibility tests and records the synchronized upstream specification revision.

Reviews (2) · Last reviewed commit: "test: claim only what the facade and the..."

Comment thread tests/test_compat.py Outdated
@chandrasekharan-zipstack chandrasekharan-zipstack changed the title Withdraw use_file_history from structure_file, sync spec to unstract#2290 [MISC] Withdraw use_file_history from structure_file, sync spec to unstract#2290 Sep 18, 2026
…antee

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014f9oEEYspPH4fmPULTnLkJ
@chandrasekharan-zipstack
chandrasekharan-zipstack merged commit f7b59ab into main Sep 18, 2026
4 checks passed
@chandrasekharan-zipstack
chandrasekharan-zipstack deleted the fix/withdraw-use-file-history branch September 18, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants