Skip to content

[FIX] Re-bump djangorestframework 3.14.0 → 3.17.1 #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandrasekharan-zipstack merged 2 commits into from
Jun 24, 2026
Merged

[FIX] Re-bump djangorestframework 3.14.0 → 3.17.1 #2105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5663c22
[FIX] Re-bump djangorestframework 3.14.0 -> 3.17.1
chandrasekharan-zipstack Jun 22, 2026
cfadefc
[FIX] Remove unused hook-check-django-migrations dep group
chandrasekharan-zipstack Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dependencies = [
"cron-descriptor==1.4.0", # For cron string description
"cryptography>=48.0.1",
"django==4.2.30",
"djangorestframework==3.14.0",
"djangorestframework==3.17.1",

@greptile-apps greptile-apps Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 drf-yasg officially supports only up to DRF 3.15

The drf-yasg PyPI page lists its compatibility matrix as DRF 3.13, 3.14, and 3.15 — even for the latest release (1.21.15, resolved in backend/uv.lock). Bumping to DRF 3.17.1 falls outside that matrix. The PR checklist already marks schema generation as unvalidated; flagging here as a reminder that runtime failures (e.g., broken AutoSchema introspection used by drf_yasg to generate Swagger docs) won't be caught by unit tests and may only surface under full server startup or API docs endpoint hits in staging.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: backend/pyproject.toml
Line: 22

Comment:
**drf-yasg officially supports only up to DRF 3.15**

The drf-yasg PyPI page lists its compatibility matrix as DRF 3.13, 3.14, and 3.15 — even for the latest release (1.21.15, resolved in `backend/uv.lock`). Bumping to DRF 3.17.1 falls outside that matrix. The PR checklist already marks schema generation as unvalidated; flagging here as a reminder that runtime failures (e.g., broken `AutoSchema` introspection used by `drf_yasg` to generate Swagger docs) won't be caught by unit tests and may only surface under full server startup or API docs endpoint hits in staging.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

"django-cors-headers==4.3.1",
# Pinning django-celery-beat to avoid build issues
"django-celery-beat==2.5.0",
Expand Down
9 changes: 4 additions & 5 deletions backend/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 0 additions & 24 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,30 +41,6 @@ test-rig = [
"requests>=2.31.0",
]

hook-check-django-migrations = [
"celery>=5.3.4",
"cron-descriptor==1.4.0",
"django==4.2.30",
"djangorestframework==3.14.0",
# Pinning django-celery-beat to avoid build issues
"django-celery-beat==2.5.0",
"django-cors-headers>=4.3.1",
"django-redis==5.4.0",
"django-tenants==3.5.0",
"drf-yasg==1.21.7",
"social-auth-app-django==5.3.0",
"psycopg2-binary==2.9.9",
"python-dotenv==1.2.2",
"python-magic==0.4.27",
"unstract-connectors",
"unstract-core",
"unstract-flags",
"unstract-tool-registry",
"unstract-tool-sandbox",
"unstract-workflow-execution",
"unstract-filesystem",
]

[tool.uv.sources]
unstract-filesystem = { path = "./unstract/filesystem", editable = true }
unstract-workflow-execution = { path = "./unstract/workflow-execution", editable = true }
Expand Down
Loading