Skip to content

fix: reutilizar NPCs existentes ao invés de recriar a cada reinício #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZzPowerTech merged 2 commits into from
Apr 15, 2026
Merged

fix: reutilizar NPCs existentes ao invés de recriar a cada reinício #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7316695
chore: adicionar .worktrees/ ao .gitignore
ZzPowerTech Apr 15, 2026
4a5d07d
fix: reutilizar NPCs existentes ao invés de recriar a cada reinício
ZzPowerTech Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,6 @@ run/
*.log
logs/

# Git Worktrees
.worktrees/

15 changes: 5 additions & 10 deletions src/main/java/plugin/centralCartTopPlugin/CentralCartTopPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,11 @@ public void onDisable() {
monthlyUpdateTask.cancel();
}

// Remove NPCs salvos para evitar duplicação em reinícios
if (npcManager != null && npcManager.isCitizensEnabled()) {
try {
npcManager.removeAllNPCs();
// Salva config para persistir remoção
saveConfig();
} catch (Exception e) {
getLogger().log(Level.SEVERE, "Erro ao remover NPCs no onDisable", e);
}
}
// Persiste os IDs dos NPCs para que sejam reutilizados no próximo onEnable.
// Os NPCs não são destruídos: o Citizens os salva e os recarrega automaticamente
// entre reinícios do servidor. Destruí-los aqui causaria a criação de novos
// NPCs a cada restart, em vez de reutilizar os existentes.
saveConfig();

getLogger().info("§c[CentralCartTopPlugin] Plugin desabilitado!");
}
Expand Down
9 changes: 4 additions & 5 deletions src/main/java/plugin/centralCartTopPlugin/service/TopNpcManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,10 @@ private void updateOrCreateNPC(NPCRegistry registry, TopCustomer customer) {
// Atualiza o nome exibido
npc.setName(displayName);

// Atualiza a skin do jogador
if (npc.hasTrait(SkinTrait.class)) {
SkinTrait skinTrait = npc.getOrAddTrait(SkinTrait.class);
skinTrait.setSkinName(customer.getName());
}
// Atualiza a skin — getOrAddTrait garante que a trait existe antes de atualizar,
// sem depender de hasTrait que deixaria NPCs sem trait herdada sem skin atualizada
SkinTrait skinTrait = npc.getOrAddTrait(SkinTrait.class);
skinTrait.setSkinName(customer.getName(), true);

// Move o NPC para a nova localização (teleporta)
if (npc.isSpawned()) {
Expand Down
Loading