Conversation
Apparently, Gamejolt updated their api with some shiny new features and bumped its version from 1.0 to 1.2. I'll resume the work on the plugin and start working on bringing it up-to-date with the new version.
These do largely already exist in the v1.2 branch but this commit contains the ones which do not. - Removed unused debug_mode var - Seperated base URL and added a switch for SSL - Simplyfied URL building by always starting with ?game_id= and appending all parameters with &...= - Some light reformatting Apart from the SSL switch I only did a few changes which (in my opinion) increased the readability significantly.
…tting errors when busy Removed signals and added user defined callbacks for each api call Added comments for all api functions Note that these changes are not tested yet
Open
Function parameters (regarding optional / often used) are matching the order of the documentation which is not usable / sometimes wrong (optional parameters not coming last)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this plugin I noticed some areas of improvement.
I added a queue for multiple requests which are worked off one after another.
I changed fixed signals for user defined callbacks definable per request.
Last but not least I did some refactoring (that is not ready yet)
Since this changes the functionality of the plugin I don't expect this pull request to get merged :D