Skip to content

Update lint hooks for Python 3.14 - #38

Merged
makermelissa merged 2 commits into
adafruit:mainfrom
makermelissa-ai-assistant:ci/pylint-python-3-14
Sep 24, 2026
Merged

makermelissa merged 2 commits into
adafruit:mainfrom
makermelissa-ai-assistant:ci/pylint-python-3-14

Conversation

@makermelissa-ai-assistant

@makermelissa-ai-assistant makermelissa-ai-assistant commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • update the REUSE pre-commit hook from 1.1.2 to 6.2.0
  • update the Pylint pre-commit hook from 2.17.4 to 4.0.9
  • remove Pylint's retired suggestion-mode option
  • suppress the new too-many-positional-arguments diagnostic alongside the existing too-many-arguments suppression for SPI.__init__
  • stop calling Sphinx RTD Theme's deprecated get_html_theme_path() helper

Why

The workflow uses python-version: '3.x', which now resolves to Python 3.14. The old Pylint hook fails while creating its environment because its setuptools stack references the removed pkgutil.ImpImporter. After updating Pylint, the old REUSE hook also fails because it imports the removed pkg_resources module.

Updating both hooks keeps CI running on the latest Python instead of pinning the workflow to an older interpreter.

Once the hooks could run, the warnings-as-errors documentation build exposed a Sphinx 9 deprecation warning. The theme is registered through its package entry point, so the deprecated path lookup is no longer needed.

Testing

Under Python 3.14.5:

  • pre-commit run --all-files
  • sphinx-build -E -W -b html . _build/html

Both pass.

AI assistance

Codex was used to diagnose the failure, update the hook configuration, and run the checks.

@makermelissa makermelissa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It has been a while since this had last been updated.

@makermelissa
makermelissa merged commit a233885 into adafruit:main Sep 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants