Remove unreachable valid_ip_address?/1 clause - #35
Merged
Merged
Conversation
adam12
force-pushed
the
fix-inet-clause-warning
branch
from
June 10, 2026 01:43
d3098db to
79d1ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elixir 1.20's stricter clause-reachability analysis flags the
valid_ip_address?(_)fallback atlib/ecto_network/inet.ex:136as never used. The sole caller (cast/1) is already guarded bywhen is_tuple(address), so theis_tuple/1clause always matches and the fallback is dead code. Removing it silences the warning; all 20 tests still pass on 1.20.1.