[pull] trunk from SeleniumHQ:trunk - #945
Merged
Merged
Conversation
…r binaries from Linux or Mac (#18029) [build] add --manager=all to cross-compile every Selenium Manager binary from one host
WebSocketConnection#send_cmd and #process_frame build the "WebSocket -> ..." and "WebSocket <- ..." strings before handing them to WebDriver.logger.debug, so every frame pays a deep Hash#inspect even though the logger discards the line at its default level. A BiDi session receives one frame per network event, so a page with many assets renders each of them for nothing; profiling a Firefox BiDi worker showed the inspect at about 3% of on-CPU time. Pass the frame to the logger as a block instead. Logger#debug already documents the block as appended to the message and only yields once the level check has passed, so the output at debug level is unchanged. Co-authored-by: Titus Fortner <titusfortner@users.noreply.github.com>
…ensions via BiDi (#17879) * [rb] add cross-browser Driver#install_web_extension, deprecating the Firefox classic install_addon methods * [rb] install web extensions on a Grid node by uploading the unpacked directory via se/file
…ow unlocks by default when dispatched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )