Skip to content

fix: DCA doesn't work when allocating (part of) funds to earn #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webbrain-one wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: DCA doesn't work when allocating (part of) funds to earn #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions krakendca/dca.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def check_account_balance(self) -> None:

:return: None
"""
trade_balance = self.ka.get_trade_balance().get("eb")
trade_balance = self.ka.get_trade_balance().get("tb")
logger.info(f"Current trade balance: {trade_balance} ZUSD.")
balance = self.ka.get_balance()
try:
Expand All @@ -190,7 +190,9 @@ def check_account_balance(self) -> None:
f"Pair balances: {pair_quote_balance} {self.pair.quote}, "
f"{pair_base_balance} {self.pair.base}."
)
if pair_quote_balance < self.amount:
# Use trade balance (tb) as the authoritative available funds
available = float(trade_balance) if trade_balance else 0
if available < self.amount:
raise ValueError(
f"Insufficient funds to buy {self.amount} "
f"{self.pair.quote} of {self.pair.base}"
Expand Down