fix: allow deleting sessions whose parent file is missing - #659
Open
fallleave001 wants to merge 1 commit into
Open
fix: allow deleting sessions whose parent file is missing#659fallleave001 wants to merge 1 commit into
fallleave001 wants to merge 1 commit into
Conversation
Deleting a session with a parentSession header whose file no longer exists (e.g. the parent was deleted or moved first) failed with an ENOENT from readSessionHeader, leaving the session undeletable. Tolerate a missing parent header file and treat it as no parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deleting a session fails with HTTP 500 when its
parentSessionheader points to a file that no longer exists:In
DELETE /api/sessions/[id](app/api/sessions/[id]/route.ts),readSessionHeader(parentSessionPath)throws when the parent file was deleted or moved first (common when fork chains span directories and the parent is removed earlier). The whole delete then fails, leaving the session undeletable via the UI permanently.Fix
Tolerate a missing parent header file and treat it as
undefined:Deleting proceeds without re-parenting children when the parent is already gone (safer than failing the whole delete).
Repro