Skip to content

Enable MicroVM Benchmarking - #691

Open
Max Smythe (maxsmythe) wants to merge 2 commits into
agent-substrate:mainfrom
maxsmythe:benchmark-uvm
Open

Enable MicroVM Benchmarking#691
Max Smythe (maxsmythe) wants to merge 2 commits into
agent-substrate:mainfrom
maxsmythe:benchmark-uvm

Conversation

@maxsmythe

Copy link
Copy Markdown
Collaborator

Currently we are unable to easily automate the benchmarking of micro VMs.

This PR:

  • Refactors the microVM setup scripts to allow discrete installation of uVM sanbox configs separate from counter demo
  • Pipes a MicroVM container test config through the benchmarking system
  • Updates default atelet daemonset to tolerate all kinds of sandboxClass taints

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, I think, one confusing nit

Comment thread hack/run-microvm-demo.sh Outdated
# 2. hack/install-microvm-deps.sh --install (asset build/stage + cluster-wide
# microvm-default SandboxConfig)
# 3. Apply the counter-microvm demo manifest (namespace + WorkerPool +
# ActorTemplate; resolves to microvm-default via sandboxClass=microvm).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 nit 🟢 – This describes the mechanism the PR deliberately rejected. The config is named microvm, not microvm-default, and sandboxconfig-microvm.yaml.tmpl says it "is deliberately NOT marked default:true" so a dirty teardown cannot silently bind new pools — binding is by explicit sandboxConfigName, which is what the demo manifest and deploy.sh both do. "Resolves to microvm-default via sandboxClass=microvm" reads as default-by-class resolution, so a reader tracing why a WorkerPool picks this config would draw the wrong conclusion.

The stale name also appears at line 24 here and in three orchestrator.py docstrings (lines 288, 294, 441).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you for spotting these. Removed/renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants