Wrap worker pod metadata into a WorkerAssignment message. - #737
Merged
Conversation
Julian Gutierrez Oschmann (juli4n)
marked this pull request as draft
August 4, 2026 18:58
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
dialer
branch
from
August 4, 2026 19:03
9b02501 to
5639192
Compare
This change formalizes the invariant that all these fields
are either all set or not. This simplifies some client code
that was just checking random worker metadata fields to see if
the actor has an assignment or not.
It also fixes a bug in `{Pause,Suspend}Actor` where we were not cleaning
up the worker pod UID field.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
dialer
branch
from
August 4, 2026 19:15
5639192 to
ccb5ff3
Compare
Julian Gutierrez Oschmann (juli4n)
marked this pull request as ready for review
August 4, 2026 19:16
Benjamin Elder (BenTheElder)
approved these changes
Aug 5, 2026
Benjamin Elder (BenTheElder)
merged commit Aug 5, 2026
4f2fd49
into
agent-substrate:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change formalizes the invariant that all these fields are either all set or not. This simplifies some client code that was just checking random worker metadata fields to see if the actor has an assignment or not.
It also fixes a bug in
{Pause,Suspend}Actorwhere we were not cleaning up the worker pod UID field.