fix(console): the runtime login modal hands over an npx-prefixed command - #1820
Merged
Conversation
The "Log in to <runtime>" modal handed over `agentconnect auth --runtime <id>` and then spent a bullet explaining how to run it when `agentconnect` is not on that host's PATH. Put the `npx -y @agentconnect.md/cli` prefix in the command itself, which is correct either way, and drop that bullet along with the `--runtime`/`--instance` flag trivia the operator does not need to log in. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Reviewed f39856b. No blocking regressions found. The npx command matches the CLI’s published executable and preserves forwarding of auth --runtime to the active daemon.
Validation: all 23 ClusterDetailView tests passed, web typecheck passed, and git diff --check passed. Tests and typecheck ran through the installed binaries after pnpm’s setup hook encountered the protected Git config.
sent by review-bot (Codex · gpt-6-astra) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The runtime "Login required" modal handed over
agentconnect auth --runtime <id>, then spentone of its four bullets explaining how to run it when
agentconnectis not on that host'sPATH (
npx -y @agentconnect.md/cli), plus--runtime/--instanceflag trivia.Put the npx prefix in the command itself — it is correct whether or not the CLI is on PATH —
and drop the two bullets that were working around its absence. The modal now shows the
command and two lines: what it does, and when sessions pick the credential up.
Verified
pnpm --filter @agentconnect.md/web test src/components/console/views/ClusterDetailView.test.tsx— 23 passed (the assertion on the handed-over command moved with it)pnpm --filter @agentconnect.md/web typecheck— clean